New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809261 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Aug 31
Cc:
█ nick@chromium.org
domenic@chromium.org
creis@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 268640
issue 806996



Sign in to add a comment

XSDB needs WPT coverage

Project Member Reported by lukasza@chromium.org, Feb 5 2018 
Let's use this bug to track adding WPT coverage for XSDB:

- Listing test ideas and figuring out what is testable

- Figuring out the process of adding tests (especially when XSDB is not yet present in any official spec).

Comment 1 by lukasza@chromium.org, Feb 5 2018

Labels: -Pri-3 Pri-2
Some test ideas:

- text/css response with a JSON parser breaker should not be blocked

- jpeg served as text/html should not be blocked (thanks to sniffing)

Also - note that many properties of XSDB might not be testable via WPT, because XSDB should be mostly transparent/invisible to the web features.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5096171c36adb5e951863b99a40eb33f8c55db5b

commit 5096171c36adb5e951863b99a40eb33f8c55db5b
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Feb 14 22:17:00 2018

CORB: WPT tests for <img> tag interactions.

Bug:  809261 ,  806996 
Change-Id: Ifb8ce26b4fb5bccf18ea22013e898b81c9654c14
Reviewed-on: https://chromium-review.googlesource.com/915103
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536844}
[modify] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/content/browser/loader/cross_origin_read_blocking_explainer.md
[modify] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/README.md
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-html-correctly-labeled.sub-expected.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-html-correctly-labeled.sub.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub-expected.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-png-mislabeled-as-html.sub-expected.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/img-png-mislabeled-as-html.sub.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/empty-labeled-as-png.png
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/empty-labeled-as-png.png.headers
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/html-correctly-labeled.html
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/html-correctly-labeled.html.headers
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-correctly-labeled.png
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-correctly-labeled.png.headers
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-mislabeled-as-html-nosniff.png
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-mislabeled-as-html-nosniff.png.headers
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-mislabeled-as-html.png
[add] https://crrev.com/5096171c36adb5e951863b99a40eb33f8c55db5b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/png-mislabeled-as-html.png.headers
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/926617b5a55ded064f11e2f71308cd26fc4f6bf4

commit 926617b5a55ded064f11e2f71308cd26fc4f6bf4
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Feb 14 23:04:58 2018

CORB: WPT tests for <script> tag interactions.

Bug:  809261 ,  806996 
Change-Id: Ia0f5acdc517f79aa9075447f8b543a141313e098
Reviewed-on: https://chromium-review.googlesource.com/917195
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536863}
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/content/browser/loader/cross_origin_read_blocking_explainer.md
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/css-with-json-parser-breaker.sub.html
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/js-mislabeled-as-html-nosniff.js
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/js-mislabeled-as-html-nosniff.js.headers
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/js-mislabeled-as-html.js
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/js-mislabeled-as-html.js.headers
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/script-html-correctly-labeled.tentative.sub.html
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/script-js-mislabeled-as-html-nosniff.sub.html
[add] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/script-js-mislabeled-as-html.sub.html
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/importscripts.js
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/script.html
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/stylesheet.html
[modify] https://crrev.com/926617b5a55ded064f11e2f71308cd26fc4f6bf4/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/worker.html
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2853b263c3d5f4c8bfc9b654760937dff3672dce

commit 2853b263c3d5f4c8bfc9b654760937dff3672dce
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Feb 14 23:28:54 2018

CORB: WPT tests for <link rel="stylesheet" href="..."> tag interactions.

Bug:  809261 ,  806996 
Change-Id: I97df15c54f72b571a7e8622c3137ec597d5244a9
Reviewed-on: https://chromium-review.googlesource.com/919171
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536877}
[modify] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/content/browser/loader/cross_origin_read_blocking_explainer.md
[delete] https://crrev.com/74914d33c83adedd38d69ba624ec542581eba19b/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/css-with-json-parser-breaker.sub.html
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/css-mislabeled-as-html-nosniff.css
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/css-mislabeled-as-html-nosniff.css.headers
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/css-mislabeled-as-html.css
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/css-mislabeled-as-html.css.headers
[modify] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/css-with-json-parser-breaker.css
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/style-css-mislabeled-as-html-nosniff.sub.html
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/style-css-mislabeled-as-html.sub.html
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/style-css-with-json-parser-breaker.sub.html
[add] https://crrev.com/2853b263c3d5f4c8bfc9b654760937dff3672dce/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/style-html-correctly-labeled.sub.html

Comment 7 by creis@chromium.org, Apr 3 2018

Cc: creis@chromium.org
Labels: -Pri-2 M-67 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Owner: lukasza@chromium.org
Status: Started (was: Untriaged)

Comment 8 by lukasza@chromium.org, Apr 11 2018

Labels: -Pri-1 Pri-2
I'd say that at this point we have sufficient WPT coverage that shouldn't anymore block spec and Blink intent discussions.  Adding remaining coverage can be treated as lower the priority.  The remaining coverage is mostly needed around sniffing and json security prefix handling.

Comment 9 by lukasza@chromium.org, May 2 2018 

We might also try to add WPT coverage for link/prefetch (ensuring that CORB blocking doesn't prevent prefetch from populating a browser-side [non-renderer-process] caache).  Nick's first unsuccessful attempt at writing this test is at https://crrev.com/c/1033814
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdca3a146ed251a8ce490324d27e91b028bf6da6

commit fdca3a146ed251a8ce490324d27e91b028bf6da6
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu May 24 14:43:22 2018

Improve description and metadata of CORB tests in WPT.

Bug:  809261 
Change-Id: I5c26d594f09a3cbbf01a4c747968a67d4d078029
Reviewed-on: https://chromium-review.googlesource.com/1066816
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561501}
[add] https://crrev.com/fdca3a146ed251a8ce490324d27e91b028bf6da6/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/OWNERS
[modify] https://crrev.com/fdca3a146ed251a8ce490324d27e91b028bf6da6/third_party/WebKit/LayoutTests/external/wpt/fetch/corb/README.md

Comment 11 by lukasza@chromium.org, Aug 31

Status: Fixed (was: Started)
►

Sign in to add a comment