Does not showing "EOL" message at settings window. |
|||||||||||||
Issue descriptionGoogle Chrome 65.0.3325.35 (Official Build) dev (64-bit) Platform 10323.9.0 (Official Build) dev-channel parrot Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)AU to M65 on Parrot (2)Reboot the device after successful AU. (3) Expected Result: Should see a notification in the uber tray and message in the settings page when you try to check for updates. Actual Result: I can see notification but no message at settings window. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 21 2018
@abodeti: Can you open the DevTools and print the values of the following commands (see [1] for related code)?
console.log(loadTimeData.getBoolean('aboutObsoleteNowOrSoon'));
console.log(loadTimeData.getBoolean('aboutObsoleteEndOfTheLine'));
[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.js?dr&l=45
,
Feb 21 2018
So based on the attached screenshot, this does not seem like a Settings UI bug. See how these values are populated at [1]. I am guessing that the notification in the tray is triggered via some different mechanism, causing the inconsistency between Settings UI and tray. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/about_handler.cc?l=304-312
,
Feb 21 2018
+thestig Settings UI, seems to be using [1], which IIUC is not related to ChromeOS. On the other hand, ChromeOS tray seems to be using [2]. Don't know what the old (pre-MD) About page did, so unclear if this is a regression or if it was always the case. [1] https://cs.chromium.org/chromium/src/chrome/browser/obsolete_system/ [2] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/eol_notification.h
,
Feb 21 2018
+some folks from bug 611816 goto/croseol-ui has a bullet point for "EoL notification when checking for update" but I have no idea if that was actually implemented.
,
Feb 21 2018
The original eol UI was implemented for the old(pre-md) about page. See patch set 10 of https://codereview.chromium.org/2060623002/#ps200001 I'm not sure if this has been added to the md about page as well. Assign to myself to investigate/add this piece of UI if not exist.
,
Feb 21 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32816fa77bef96fdbb306a65352a1f3c1bc91a74 commit 32816fa77bef96fdbb306a65352a1f3c1bc91a74 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Wed Feb 28 02:20:38 2018 cros: Add device end of life message in md about page. Chrome OS devices receive new feature Stable updates every six weeks, these updates are for at least five years from the time devices are launched, after 5 years the new feature updates are no longer guaranteed and devices will eventually stop receiving updates. At this point, the device will be considered End of Life. The about page retrieves the end of life status(supported or end of life) from update engine and show a message, an end of life icon, as well as an link for more information: https://www.google.com/chromebook/older/ when status == end of life. Bug: 809258 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18568894a88cb8e1aabdf22613f748eb8bfbf8be Reviewed-on: https://chromium-review.googlesource.com/936448 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#539661} [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/chromeos/eol_notification.cc [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/ui/webui/help/version_updater.h [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/ui/webui/help/version_updater_chromeos.cc [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/ui/webui/help/version_updater_chromeos.h [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/ui/webui/settings/about_handler.cc [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/browser/ui/webui/settings/about_handler.h [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chrome/test/data/webui/settings/about_page_tests.js [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chromeos/dbus/fake_update_engine_client.cc [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chromeos/dbus/fake_update_engine_client.h [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chromeos/dbus/update_engine_client.cc [modify] https://crrev.com/32816fa77bef96fdbb306a65352a1f3c1bc91a74/chromeos/dbus/update_engine_client.h
,
Feb 28 2018
,
Feb 28 2018
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 28 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63bda12943e1e3da8382bb8817f3ed7392e4eb1a commit 63bda12943e1e3da8382bb8817f3ed7392e4eb1a Author: Sarah Hu <xiaoyinh@chromium.org> Date: Wed Feb 28 19:21:00 2018 [Merge to M65]cros: Add device end of life message in md about page. Chrome OS devices receive new feature Stable updates every six weeks, these updates are for at least five years from the time devices are launched, after 5 years the new feature updates are no longer guaranteed and devices will eventually stop receiving updates. At this point, the device will be considered End of Life. The about page retrieves the end of life status(supported or end of life) from update engine and show a message, an end of life icon, as well as an link for more information: https://www.google.com/chromebook/older/ when status == end of life. TBR=stevenjb@chromium.org,michaelpg@chromium.org (cherry picked from commit 32816fa77bef96fdbb306a65352a1f3c1bc91a74) Bug: 809258 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18568894a88cb8e1aabdf22613f748eb8bfbf8be Reviewed-on: https://chromium-review.googlesource.com/936448 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#539661} Reviewed-on: https://chromium-review.googlesource.com/941793 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#627} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/chromeos/eol_notification.cc [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/ui/webui/help/version_updater.h [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/ui/webui/help/version_updater_chromeos.cc [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/ui/webui/help/version_updater_chromeos.h [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/ui/webui/settings/about_handler.cc [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/browser/ui/webui/settings/about_handler.h [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chrome/test/data/webui/settings/about_page_tests.js [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chromeos/dbus/fake_update_engine_client.cc [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chromeos/dbus/fake_update_engine_client.h [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chromeos/dbus/update_engine_client.cc [modify] https://crrev.com/63bda12943e1e3da8382bb8817f3ed7392e4eb1a/chromeos/dbus/update_engine_client.h
,
Feb 28 2018
,
Mar 1 2018
,
Mar 2 2018
Google Chrome 65.0.3325.114 (Official Build) beta (64-bit) Platform 10323.48.0 (Official Build) beta-channel lumpy Firmware Version Google_Lumpy.2.111.0 |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bhthompson@google.com
, Feb 21 2018