New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809250 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

board/*/build.mk is included twice

Project Member Reported by dnojiri@chromium.org, Feb 5 2018

Issue description

It seems board/*/build.mk is included twice. So, a rule is defined there Make complains:

  board/fizz/build.mk:25
  foo:
      echo 'hello'

Then running 'make BOARD=fizz foo' gives you,

  board/fizz/build.mk:25: warning: overriding recipe for target 'foo'
  board/fizz/build.mk:22: warning: ignoring old recipe for target 'foo'
 
Cc: rspangler@chromium.org
Cc: drinkcat@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/9fb49a0df1e1f8cf9c53412bba4dbc333c5850f9

commit 9fb49a0df1e1f8cf9c53412bba4dbc333c5850f9
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Fri Feb 16 15:46:15 2018

Fizz/CBI: Buid cbi-util as host-util

This patch also removes make rules to stop producing CBI blobs.
CBI blobs will be produced by another protage package.

BUG=b:73123025,chromium:809250
BRANCH=none
TEST=emerge-fizz chromeos-firmware-fizz and verify
/build/fizz/firmware/cbi contains EEPROM images.
Verify emerge ec-utils ec-devutils succeeds.

Change-Id: I13744b0ab97675afa0247046bffa3edac3e62ceb
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/909692

[modify] https://crrev.com/9fb49a0df1e1f8cf9c53412bba4dbc333c5850f9/board/fizz/build.mk
[modify] https://crrev.com/9fb49a0df1e1f8cf9c53412bba4dbc333c5850f9/util/build.mk

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1db0f0e06ec72f0b63362396ea4898dafa883bd

commit a1db0f0e06ec72f0b63362396ea4898dafa883bd
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Sun Feb 18 10:15:19 2018

Install ec-utils as cros sdk

cbi-util is used to build EEPROM images for boards which support
Cros Board Info. It's used by chromeos-firmware-fizz, for example.

This patch adds ec-utils package to cros sdk so that cbi-util
except other ec tools will be installed under /usr/bin.

CQ-DEPEND=CL:909692
BUG=b:73123025,chromium:809250
BRANCH=none
TEST=emerge ec-utils && emerge-fizz chromeos-firmware-fizz and verify
/build/fizz/firmware/cbi contains EEPROM images.

Change-Id: I9f09ac52f1f6a354776949dc2fb45995e8fa8a5e
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/909707

[modify] https://crrev.com/a1db0f0e06ec72f0b63362396ea4898dafa883bd/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
[modify] https://crrev.com/a1db0f0e06ec72f0b63362396ea4898dafa883bd/chromeos-base/ec-utils/ec-utils-9999.ebuild
[rename] https://crrev.com/a1db0f0e06ec72f0b63362396ea4898dafa883bd/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r99.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 19 2018

Labels: merge-merged-firmware-fizz-10139.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e1e69147d92d94b9c5cbdaa78d5b3121fb9489c0

commit e1e69147d92d94b9c5cbdaa78d5b3121fb9489c0
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Mon Feb 19 18:50:50 2018

Install ec-utils as cros sdk

cbi-util is used to build EEPROM images for boards which support
Cros Board Info. It's used by chromeos-firmware-fizz, for example.

This patch adds ec-utils package to cros sdk so that cbi-util
except other ec tools will be installed under /usr/bin.

CQ-DEPEND=CL:909692
BUG=b:73123025,chromium:809250
BRANCH=none
TEST=emerge ec-utils && emerge-fizz chromeos-firmware-fizz and verify
/build/fizz/firmware/cbi contains EEPROM images.

Change-Id: I9f09ac52f1f6a354776949dc2fb45995e8fa8a5e
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/909707
Reviewed-on: https://chromium-review.googlesource.com/925452

[modify] https://crrev.com/e1e69147d92d94b9c5cbdaa78d5b3121fb9489c0/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
[modify] https://crrev.com/e1e69147d92d94b9c5cbdaa78d5b3121fb9489c0/chromeos-base/ec-utils/ec-utils-9999.ebuild
[rename] https://crrev.com/e1e69147d92d94b9c5cbdaa78d5b3121fb9489c0/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r91.ebuild

Sign in to add a comment