New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 823897

Blocking:
issue 869214



Sign in to add a comment
link

Issue 809249: [Media Router] In-browser Cast MRP

Reported by imch...@chromium.org, Feb 5 2018 Project Member

Issue description

Tracker bug for in-browser Cast MRP implementation.
 

Comment 1 by imch...@chromium.org, Feb 22 2018

Regarding the *_RESCAN AppAvailability statuses in the current extension implementation:

There are 2 additional availability states in the current implementation: available_rescan and unavailable_rescan. Essentially, an available/unavailable status for a (sink, appId) becomes their _rescan counterpart instead of being discarded when there are no more queries for that appId. By doing this we keep the cached result that can be returned immediately when a sink query for that appId is re-added, but we also re-query the app availability.

I think an alternative approach without the use of _rescan statuses is to:

- retain available/unavailable results even after there are no more queries for the appId
0 rescan unknown/unavailable on user gesture. IIRC, unavailable can become available later due to delayed retrieval of the app list by the receiver.
- It's far less common for available to become unavailable. If we want to account for this, we can cache the result for an hour only.

Comment 2 by imch...@chromium.org, Feb 22 2018

Regarding broadcast requests: these are currently implemented as getAvailability calls in the Cast SDK where the URL contains a broadcast-specific parameter. This is handled as a sink query in the Cast MRP. We will need to implement logic to special case this in the in-browser Cast MRP.

Comment 3 by amp@chromium.org, Mar 30 2018

Labels: -M-67 M-68

Comment 4 by imch...@chromium.org, Apr 12 2018

Blockedon: 823897
Based on conversation with chrome-security@, JSON parsing for Cast messages should be done out-of-process using the data_decoder service. Given the frequency of messages, it would be ideal to have batching support.

Comment 5 by bugdroid1@chromium.org, May 23 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b

commit 815d55c0e9156425b7b4337bb2a49ea7f0d04f4b
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed May 23 02:39:04 2018

[Cast MRP] In-browser Cast MRP part 1.

This patch introduces message formats for launching sessions on a Cast
device and corresponding CastMessageHandler API. It also adds APIs for
opening a virtual connection for a (sourceId,destId) pair, and
forwarding an app message from Cast SDK client to the device.

Also organized cast_message_utils to map message types to strings.

Bug: 809249
Change-Id: I63d4f658e53579d6a761a8857508534ad993ebc4
Reviewed-on: https://chromium-review.googlesource.com/1060087
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560905}
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/chrome/browser/media/router/providers/cast/chrome_cast_message_handler.cc
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/chrome/browser/media/router/providers/cast/chrome_cast_message_handler.h
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/BUILD.gn
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_util.h
[add] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/815d55c0e9156425b7b4337bb2a49ea7f0d04f4b/components/cast_channel/cast_test_util.cc

Comment 6 by imch...@chromium.org, Jun 11 2018

Labels: -M-68 M-69

Comment 7 by bugdroid1@chromium.org, Jun 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c4c420606ef2166f64840d1ceceab21bf1929ff

commit 5c4c420606ef2166f64840d1ceceab21bf1929ff
Author: Derek Cheng <imcheng@chromium.org>
Date: Mon Jun 11 23:05:54 2018

[Cast MRP] Implement capabilities filtering.

In addition to app availability, the CastAppDiscoveryService will now
check the required capabilities in the MediaSource against the
capabilities supported by a sink. A sink is only returned if both
conditions are satisfied.

Bug: 809249
Change-Id: I5c6f3685db44b28560c575892637117e9ad8d711
Reviewed-on: https://chromium-review.googlesource.com/1089461
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566191}
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_availability_tracker.cc
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_availability_tracker.h
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_availability_tracker_unittest.cc
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_discovery_service.h
[modify] https://crrev.com/5c4c420606ef2166f64840d1ceceab21bf1929ff/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc

Comment 8 by bugdroid1@chromium.org, Jun 20 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd

commit 38bf74b3ad7901cbafba78a7c058f4d90ebae9bd
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Jun 20 17:52:18 2018

Revert "[Cast MRP] Implement capabilities filtering."

This reverts commit 5c4c420606ef2166f64840d1ceceab21bf1929ff.

Reason for revert: Capabilities filtering broke Cast SDK integration

Original change's description:
> [Cast MRP] Implement capabilities filtering.
> 
> In addition to app availability, the CastAppDiscoveryService will now
> check the required capabilities in the MediaSource against the
> capabilities supported by a sink. A sink is only returned if both
> conditions are satisfied.
> 
> Bug: 809249
> Change-Id: I5c6f3685db44b28560c575892637117e9ad8d711
> Reviewed-on: https://chromium-review.googlesource.com/1089461
> Commit-Queue: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566191}

TBR=imcheng@chromium.org,takumif@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 809249
Change-Id: Ic8533a927bfbb30b7f60dbdb7e7e1a7cde50e102
Reviewed-on: https://chromium-review.googlesource.com/1106500
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568914}
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_availability_tracker.cc
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_availability_tracker.h
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_availability_tracker_unittest.cc
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_discovery_service.h
[modify] https://crrev.com/38bf74b3ad7901cbafba78a7c058f4d90ebae9bd/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc

Comment 9 by bugdroid1@chromium.org, Jul 24 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8

commit 23a0140b1ad35ca48fd8a78cbcea29856a5e69f8
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Jul 24 13:38:14 2018

[Cast MRP] In-browser Cast MRP part 2a.

Add utility class that handles messages between a Cast SDK client and
the Cast MRP ("internal messages"). The types of internal messages are:
- new session (mrp -> client)
- receiver action (mrp -> client)
- client connect (client -> mrp)
- app message (client <-> mrp)

In particular, client connect should be going away soon (with the use
of PresentationConnection in MRP). app message is bi-directional between
the client and the receiver device, where MRP acts as a pass through.


Also added a utility method to generate a stop session cast channel
message for a given receiver device and session id.


Bug: 809249
Change-Id: I62169dd5b163060464cc6d389c8d93fc4bb2425f
Reviewed-on: https://chromium-review.googlesource.com/1085768
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577506}
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/media_router_feature.h
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/media_router_feature_unittest.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/providers/cast/cast_app_availability_tracker_unittest.cc
[add] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[add] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[add] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/media/router/providers/cast/cast_media_route_provider_unittest.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/common/media_router/providers/cast/cast_media_source.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/common/media_router/providers/cast/cast_media_source.h
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/common/media_router/providers/cast/cast_media_source_unittest.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/chrome/test/BUILD.gn
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/23a0140b1ad35ca48fd8a78cbcea29856a5e69f8/components/cast_channel/cast_message_util_unittest.cc

Comment 10 by mfo...@chromium.org, Jul 24 2018

Labels: -M-69 Target-70 M-70

Comment 11 by imch...@chromium.org, Jul 30 2018

Blocking: 869214

Comment 13 by bugdroid1@chromium.org, Aug 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f3802a491531f9d22a92a338b4905fa60afdb4

commit 19f3802a491531f9d22a92a338b4905fa60afdb4
Author: Derek Cheng <imcheng@chromium.org>
Date: Mon Aug 13 18:28:47 2018

[Cast channel] No JSON parsing in KeepAliveDelegate.

Due to the way cast message delegates are layered, a cast message coming
from a receiver first goes through KeepAliveDelegate, which inspects the
message for keep-alive type and passes it through if it is not a
ping/pong message. Instead of doing JSON parsing (which isn't safe in
browser process), we will check for the heartbeat namespace and do a
quick substring check for PING/PONG type.

Also removed the now unused function and clean up tests to move usage
of JSONReader to the test itself.

Change-Id: I3c906b8215f7b7149b18c014278cdad3bdf6b3e7
Bug: 809249
Reviewed-on: https://chromium-review.googlesource.com/1170130
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582647}
[modify] https://crrev.com/19f3802a491531f9d22a92a338b4905fa60afdb4/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/19f3802a491531f9d22a92a338b4905fa60afdb4/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/19f3802a491531f9d22a92a338b4905fa60afdb4/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/19f3802a491531f9d22a92a338b4905fa60afdb4/components/cast_channel/keep_alive_delegate.cc

Comment 14 by mfo...@chromium.org, Sep 4

Labels: -Target-70 -M-70 Target-71

Comment 15 by bugdroid1@chromium.org, Sep 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c673efc1030ddb40dcb3ff515d277bc3ce17aa

commit 05c673efc1030ddb40dcb3ff515d277bc3ce17aa
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Sep 04 21:42:28 2018

[Cast channel] Use data_decoder service to parse JSON messages.

Bug: 809249
Change-Id: I6b64501fa2b7d0a3ecb828a1a88a2d89e11d721b
Reviewed-on: https://chromium-review.googlesource.com/1171739
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588650}
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/chrome/browser/media/router/data_decoder_util.cc
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/chrome/browser/media/router/data_decoder_util.h
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/chrome/browser/media/router/providers/cast/chrome_cast_message_handler.cc
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/BUILD.gn
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/DEPS
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/05c673efc1030ddb40dcb3ff515d277bc3ce17aa/components/cast_channel/cast_test_util.cc

Comment 16 by bugdroid1@chromium.org, Sep 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96efbf67188567dc65e6c5ce9eba4215b0e3cf51

commit 96efbf67188567dc65e6c5ce9eba4215b0e3cf51
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Sep 05 18:37:09 2018

[Cast MRP] Use app availability caching when adding sink query.

The availability caching will now be checked when a new sink query is
added. Before that, it is only checked during Refresh() (user gesture)
and when sink is added. This prevents a request from being re-sent if
a query was removed and re-added while the sink is still on the list.
In addition, the cache rule now applies when a sink is added or
updated. This means a request will be re-sent (subject to timing
threshold) if its cached availability is kUnavailable.

Note the rule to always use cache if the availability value is
kAvailable hasn't changed. An app is considered to be available until
it is offline, at which point the cache value will be invalidated.

Bug: 809249
Change-Id: Iadcee4953b51464211c3ee91777683a640f1291a
Reviewed-on: https://chromium-review.googlesource.com/1173477
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588947}
[modify] https://crrev.com/96efbf67188567dc65e6c5ce9eba4215b0e3cf51/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/96efbf67188567dc65e6c5ce9eba4215b0e3cf51/chrome/browser/media/router/providers/cast/cast_app_discovery_service.h
[modify] https://crrev.com/96efbf67188567dc65e6c5ce9eba4215b0e3cf51/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc

Comment 17 by bugdroid1@chromium.org, Sep 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143f1e0fcb0909f668b24f8b43f5e0897735f16d

commit 143f1e0fcb0909f668b24f8b43f5e0897735f16d
Author: Derek Cheng <imcheng@chromium.org>
Date: Mon Sep 10 19:41:30 2018

[Cast MRP] Add CastActivityManager

CastActivityManager manages the lifetime of routes and corresponding
Cast sessions. This patch implements the minimum amount of message
handling necessary to launch a Cast session via CreateRoute() (to be
hooked up to CastMediaRouteProvider in next patch).

Bug: 809249
Change-Id: Ib6058a01d62113f8de1748cd2d9ca3dadabe8e49
Reviewed-on: https://chromium-review.googlesource.com/1159357
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590027}
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/BUILD.gn
[add] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[add] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[add] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/browser/media/router/providers/dial/dial_activity_manager.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/common/media_router/media_route.h
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/chrome/test/BUILD.gn
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/143f1e0fcb0909f668b24f8b43f5e0897735f16d/third_party/blink/renderer/modules/presentation/presentation_connection.cc

Comment 18 by bugdroid1@chromium.org, Sep 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbef7ceb2f96b7fd6699ea234c57e247137dad09

commit cbef7ceb2f96b7fd6699ea234c57e247137dad09
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Sep 18 00:03:25 2018

[Cast MRP] Connect CastMRP to CastActivityManager.

With this patch, it will now be possible to launch and terminate a
Cast app using the native CastMRP. Note that only the initial sequence
of Cast messages exchanged between the SDK/MRP/receiver for session
launch is supported, e.g. media commands, receiver status, etc., will
be implemented in a future patch.

Bug: 809249
Change-Id: Id9639e2523b91dbb0252c39b2e9bcae76a1fbb4a
Reviewed-on: https://chromium-review.googlesource.com/1168388
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591885}
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/mojo/media_router_desktop.h
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_media_route_provider.cc
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_media_route_provider.h
[modify] https://crrev.com/cbef7ceb2f96b7fd6699ea234c57e247137dad09/chrome/browser/media/router/providers/cast/cast_media_route_provider_unittest.cc

Comment 19 by imch...@chromium.org, Sep 24

Owner: ----
Status: Available (was: Assigned)

Comment 20 by imch...@chromium.org, Sep 24

Labels: -Target-71

Comment 21 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1

commit ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1
Author: John Williams <jrw@google.com>
Date: Fri Jan 04 00:47:14 2019

[Cast MRP] Implement RECEIVER_STATUS support.

Forked from https://chromium-review.googlesource.com/c/chromium/src/+/1178225

This patch introduces CastSessionTracker, which is a singleton that
listens for RECEIVER_STATUS messages and keeps track of CastSession
object for each Cast MediaSink. It also exposes an Observer interface
for CastActivityManagers to listen for session changes in order to
update MediaRoutes.

Also, added logic to terminate existing session (if any) when trying to
launch a new session. Refactored launch parameters into a struct to
keep the number of input params down.

Bug: 809249
Change-Id: Ieb38e26d7b8191390f2fea5a8c41ea8955cbc352
Reviewed-on: https://chromium-review.googlesource.com/c/1297299
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619834}
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_app_availability_tracker_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_media_route_provider.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_media_route_provider.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_media_route_provider_unittest.cc
[add] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[add] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[add] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/common/media_router/providers/cast/cast_media_source.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/common/media_router/providers/cast/cast_media_source.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/common/media_router/providers/cast/cast_media_source_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/chrome/test/BUILD.gn
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/ea101331f4a7d3e8f4f5e10cca4266fe0cf252c1/components/cast_channel/cast_test_util.h

Comment 22 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/808c0071aaa9ec067d1dcbb69090d40156960a98

commit 808c0071aaa9ec067d1dcbb69090d40156960a98
Author: John Williams <jrw@google.com>
Date: Sat Jan 12 01:37:29 2019

[Cast MRP] Media commands, media status, and SET_VOLUME.

Forked from https://chromium-review.googlesource.com/c/chromium/src/+/1234371

This patch implements media commands sent from the SDK to the receiver,
as well as media status messages from the receiver to the SDK.

This patch also implements the SET_VOLUME message which sets the system
level volume and not considered part of media commands.

Bug: 809249
Change-Id: Ib6d0a8764ca16ec9f0c5748df16e2a7c3f972be0
Reviewed-on: https://chromium-review.googlesource.com/c/1372666
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622254}
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/media_route.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/chrome/common/media_router/media_source.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_socket.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/808c0071aaa9ec067d1dcbb69090d40156960a98/components/cast_channel/keep_alive_delegate.cc

Comment 23 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a

commit 0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Jan 12 05:01:42 2019

Revert "[Cast MRP] Media commands, media status, and SET_VOLUME."

This reverts commit 808c0071aaa9ec067d1dcbb69090d40156960a98.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 622254 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgwOGMwMDcxYWFhOWVjMDY3ZDFkY2JiNjkwOTBkNDAxNTY5NjBhOTgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/46830

Sample Failed Step: unit_tests

Original change's description:
> [Cast MRP] Media commands, media status, and SET_VOLUME.
> 
> Forked from https://chromium-review.googlesource.com/c/chromium/src/+/1234371
> 
> This patch implements media commands sent from the SDK to the receiver,
> as well as media status messages from the receiver to the SDK.
> 
> This patch also implements the SET_VOLUME message which sets the system
> level volume and not considered part of media commands.
> 
> Bug: 809249
> Change-Id: Ib6d0a8764ca16ec9f0c5748df16e2a7c3f972be0
> Reviewed-on: https://chromium-review.googlesource.com/c/1372666
> Commit-Queue: John Williams <jrw@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622254}

Change-Id: I9b92076738ec5038e93e96c1c12ac2e0cdf3ed8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809249
Reviewed-on: https://chromium-review.googlesource.com/c/1407266
Cr-Commit-Position: refs/heads/master@{#622292}
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/media_route.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/chrome/common/media_router/media_source.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_socket.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/0163ca1bd8dad5a90c2fa4ce6131dddd9a20375a/components/cast_channel/keep_alive_delegate.cc

Comment 24 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d627b6289d62504a5f62280c7eeab35f1a08914

commit 7d627b6289d62504a5f62280c7eeab35f1a08914
Author: John Williams <jrw@google.com>
Date: Mon Jan 14 21:05:34 2019

[Cast MRP] Media commands, media status, and SET_VOLUME.

Re-roll of https://chromium-review.googlesource.com/c/chromium/src/+/1372666

This patch implements media commands sent from the SDK to the receiver,
as well as media status messages from the receiver to the SDK.

This patch also implements the SET_VOLUME message which sets the system
level volume and not considered part of media commands.

Bug: 809249
Change-Id: If6569aa926c9a458f516f8ca9593a331c1916662
Reviewed-on: https://chromium-review.googlesource.com/c/1372666
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#622254}
Reviewed-on: https://chromium-review.googlesource.com/c/1407303
Cr-Commit-Position: refs/heads/master@{#622597}
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/media_route.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/chrome/common/media_router/media_source.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_socket.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/7d627b6289d62504a5f62280c7eeab35f1a08914/components/cast_channel/keep_alive_delegate.cc

Comment 25 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393bb70b5725c96f32b7ecacb0405a2c8ac42e83

commit 393bb70b5725c96f32b7ecacb0405a2c8ac42e83
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Mon Jan 14 21:52:54 2019

Revert "[Cast MRP] Media commands, media status, and SET_VOLUME."

This reverts commit 7d627b6289d62504a5f62280c7eeab35f1a08914.

Reason for revert: Causes test failures on linux-chromeos-rel, See  crbug.com/921751  for details.

BUG= 921751 

Original change's description:
> [Cast MRP] Media commands, media status, and SET_VOLUME.
> 
> Re-roll of https://chromium-review.googlesource.com/c/chromium/src/+/1372666
> 
> This patch implements media commands sent from the SDK to the receiver,
> as well as media status messages from the receiver to the SDK.
> 
> This patch also implements the SET_VOLUME message which sets the system
> level volume and not considered part of media commands.
> 
> Bug: 809249
> Change-Id: If6569aa926c9a458f516f8ca9593a331c1916662
> Reviewed-on: https://chromium-review.googlesource.com/c/1372666
> Commit-Queue: John Williams <jrw@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#622254}
> Reviewed-on: https://chromium-review.googlesource.com/c/1407303
> Cr-Commit-Position: refs/heads/master@{#622597}

TBR=mfoltz@chromium.org,takumif@chromium.org,jrw@chromium.org

Change-Id: I21fe1c15fff39f9409fa14ccfe994387bd2da5d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809249
Reviewed-on: https://chromium-review.googlesource.com/c/1409911
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622619}
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_route.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_source.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_socket.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/keep_alive_delegate.cc

Comment 26 by taku...@chromium.org, Jan 16

Owner: jrw@chromium.org
Status: Started (was: Available)

Comment 27 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e955a2481f88f7d146852da11e060839a5a21913

commit e955a2481f88f7d146852da11e060839a5a21913
Author: John Williams <jrw@google.com>
Date: Sat Jan 19 01:35:00 2019

[Re-land] [Cast MRP] Media commands, media status, and SET_VOLUME.

Third attempt.  Previous versions here:
https://chromium-review.googlesource.com/c/chromium/src/+/1407303
https://chromium-review.googlesource.com/c/chromium/src/+/1372666

This patch implements media commands sent from the SDK to the receiver,
as well as media status messages from the receiver to the SDK.

This patch also implements the SET_VOLUME message which sets the system
level volume and not considered part of media commands.

Bug: 809249
Change-Id: Icc2f8d618b86ad2c422de3d11fdb1f870453968b
Reviewed-on: https://chromium-review.googlesource.com/c/1372666
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#622254}
Reviewed-on: https://chromium-review.googlesource.com/c/1407303
Cr-Original-Commit-Position: refs/heads/master@{#622597}
Reviewed-on: https://chromium-review.googlesource.com/c/1419204
Cr-Commit-Position: refs/heads/master@{#624402}
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/media_route.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/chrome/common/media_router/media_source.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_socket.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/e955a2481f88f7d146852da11e060839a5a21913/components/cast_channel/keep_alive_delegate.cc

Sign in to add a comment