New issue
Advanced search Search tips

Issue 809246 link

Starred by 1 user
Status: Fixed
Owner:
philipchen@chromium.org
Closed: Feb 2018
Cc:
philipchen@chromium.org
amstan@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ec: charger/rt946x: Set up pre-charge current

Project Member Reported by philipchen@chromium.org, Feb 5 2018 
We should set up pre-charge current during rt946x init.
Pre-charge current is dependent on battery pack and stored in struct battery_info in board/battery.c.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/c715d819553ebf70c6261ebccf25a5af366523d5

commit c715d819553ebf70c6261ebccf25a5af366523d5
Author: Philip Chen <philipchen@google.com>
Date: Tue Feb 06 23:41:21 2018

charger/rt946x: Set up pre-charge current

We should set up pre-charge current based on the battery pack we use.
By default this parameter is 150mA.

BUG= chromium:809246 
BRANCH=none
TEST=confirm IPREC register is written correctly

Change-Id: I2cb0906c74bef144d80c38b5d15519d594ed42f2
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/902945
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/c715d819553ebf70c6261ebccf25a5af366523d5/driver/charger/rt946x.c
[modify] https://crrev.com/c715d819553ebf70c6261ebccf25a5af366523d5/driver/charger/rt946x.h

Comment 2 by philipchen@chromium.org, Feb 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment