New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809233 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 662644
issue 800073
issue angleproject:2994
issue 911216


Participants' hotlists:
webgl-conformance-all


Sign in to add a comment

conformance2/textures/misc/copy-texture-image-same-texture.html fails on Linux/Mac/Win

Project Member Reported by zmo@chromium.org, Feb 5 2018

Issue description

The test is added as a regression test for  crbug.com/797235 
 
Labels: OS-Windows
Summary: conformance2/textures/misc/copy-texture-image-same-texture.html fails on Linux/Mac/Win (was: conformance2/textures/misc/copy-texture-image-same-texture.html fails on Linux/Mac)
Cc: geoffl...@chromium.org danakj@chromium.org
 Issue 809594  has been merged into this issue.
 Issue 809594  was another report of this test failing, but on Windows. Expanding the scope of this bug.
Blocking: 800073
Labels: OS-Android
Also failing on Android.
Blocking: 662644
Labels: webgl-conformance
Owner: jdarpinian@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6829aab5f8698d265317183be5e6e50e4551edf9

commit 6829aab5f8698d265317183be5e6e50e4551edf9
Author: James Darpinian <jdarpinian@chromium.org>
Date: Thu Nov 29 00:44:19 2018

Add suppressions for Pixel 2 and Nvidia Shield TV

We're not yet enabling the tests to run on the waterfall due to lack
of hardware, but the tests currently pass with these suppressions.

Bug: 709351,  809233 , 830046, 850257,  874620 
Bug: 905006, 906735, 906735, 906737, 906739
Bug: 906740, 906742,  906743 , 906745, 906752
Change-Id: I7362e52e9df8ae8f591d11a4a1e272fa2b81b0b6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1340275
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611965}
[modify] https://crrev.com/6829aab5f8698d265317183be5e6e50e4551edf9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Found the problem. When we emulate GL_LUMINANCE_ALPHA using GL_RG and swizzles, we need to make sure to update the swizzles whenever the base level of the texture changes, because different levels can have different formats that need different swizzles.
Blocking: angleproject:2994
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d645c7b4c71d02f1393e6e70e9402d00b7d1b4b2

commit d645c7b4c71d02f1393e6e70e9402d00b7d1b4b2
Author: James Darpinian <jdarpinian@chromium.org>
Date: Sat Dec 01 02:21:09 2018

gpu: Update swizzles when texture base level changes

When we emulate GL_LUMINANCE_ALPHA using GL_RG and swizzles, we need to
make sure to update the swizzles whenever the base level of the texture
changes, because different levels can have different formats that need
different swizzles.

Fixes WebGL test
conformance2/textures/misc/copy-texture-image-same-texture.html

Bug:  809233 
Change-Id: Iccda944688982ca1d67203b885cd3ea5236c7e26
Reviewed-on: https://chromium-review.googlesource.com/c/1356330
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612908}
[modify] https://crrev.com/d645c7b4c71d02f1393e6e70e9402d00b7d1b4b2/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/d645c7b4c71d02f1393e6e70e9402d00b7d1b4b2/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/d645c7b4c71d02f1393e6e70e9402d00b7d1b4b2/gpu/command_buffer/service/texture_manager.h

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
WebglConformance_conformance2_textures_misc_copy_texture_image_same_texture fails on Linux FYI Release (AMD R7 240) after the CL in #12 landed.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29/2379

Please take a look, maybe restoring the fail expectation is good enough.

  AssertionError: should be 0,0,0,0
  at (0, 32) expected: 0,0,0,0 was 255,0,0,255
  FAIL should be 0,0,0,0
  at (0, 32) expected: 0,0,0,0 was 255,0,0,255
  should be 0,0,0,0
  at (32, 32) expected: 0,0,0,0 was 255,0,0,255
  FAIL should be 0,0,0,0
  at (32, 32) expected: 0,0,0,0 was 255,0,0,255
  should be 255,255,255,255
  at (0, 0) expected: 255,255,255,255 was 0,0,0,225
  FAIL should be 255,255,255,255
  at (0, 0) expected: 255,255,255,255 was 0,0,0,225
If the test passes on Linux Intel then let's just re-suppress this configuration as a driver bug. That AMD machine has an old GPU and driver.

Yes, I will suppress the failure.
Blocking: 911216
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92727df91ca721a47653bf00fd92543c413e28e6

commit 92727df91ca721a47653bf00fd92543c413e28e6
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Dec 03 20:43:25 2018

WebGL: suppress AMD test failure

conformance2/textures/misc/copy-texture-image-same-texture.html is
failing on AMD even after http://crrev.com/c/1356330. Suppressing the
failure.

TBR: kbr@chromium.org
Bug:  809233 , 911216
Change-Id: I56138fe20025eb4836f9b588755fcdc71ba88055
Reviewed-on: https://chromium-review.googlesource.com/c/1359129
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613230}
[modify] https://crrev.com/92727df91ca721a47653bf00fd92543c413e28e6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: Fixed (was: Assigned)
Further work can happen in bug 911216.

Sign in to add a comment