lulu: laptop mode error: failed - udev not active? |
||||||||||||
Issue descriptionLooking at error messages on Lulu ( https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos4-row6-rack3-host5/126835-cleanup), installing lulu-release/R65-10323.15.0 2018-02-05T17:16:29.001375+00:00 ERR laptop-mode[2263]: failed - udev not active? The problem is in /usr/share/laptop-mode-tools/modules/hdparm is_capable is looking for udevadm in /sbin, while it is in /bin. Other part of the script are using 'which'.
,
Feb 6 2018
The changed path stems from the upgrade to udev-225 (CL:409017) in M57. laptop-mode-tools is going to be retired, possibly as early as this week, but we probably still want a fix for older versions.
,
Feb 6 2018
I will post a simple patch then.
,
Feb 8 2018
This is needed to address b/697805, an issue with older models that has been plagued user for a while.
,
Feb 8 2018
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/58f52d6f0953bcabf680a3363f3f5a23f572e69f commit 58f52d6f0953bcabf680a3363f3f5a23f572e69f Author: Gwendal Grignou <gwendal@chromium.org> Date: Thu Feb 08 20:58:18 2018 laptop-mode-tools: Fix udevadm location udevadmn is now in /bin since CL:568592 BUG= chromium:809225 TEST=trybot on fizz, messages: """laptop-mode[1549]: failed - udev not active?""" gone. Change-Id: I53eb5886ccef1d037213a61aef3898a5b37904e6 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/905442 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> [rename] https://crrev.com/58f52d6f0953bcabf680a3363f3f5a23f572e69f/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r45.ebuild [add] https://crrev.com/58f52d6f0953bcabf680a3363f3f5a23f572e69f/app-laptop/laptop-mode-tools/files/0039-Fix-hdparm-udevadm-location.patch [modify] https://crrev.com/58f52d6f0953bcabf680a3363f3f5a23f572e69f/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild
,
Feb 9 2018
,
Feb 9 2018
,
Feb 13 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f22c57ab08f4915395887968b29a05a2c9fbd7b1 commit f22c57ab08f4915395887968b29a05a2c9fbd7b1 Author: Gwendal Grignou <gwendal@chromium.org> Date: Tue Feb 13 17:42:52 2018 laptop-mode-tools: Fix udevadm location udevadmn is now in /bin since CL:568592 BUG= chromium:809225 TEST=trybot on fizz, messages: """laptop-mode[1549]: failed - udev not active?""" gone. Change-Id: I53eb5886ccef1d037213a61aef3898a5b37904e6 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/905442 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> (cherry picked from commit 58f52d6f0953bcabf680a3363f3f5a23f572e69f) Reviewed-on: https://chromium-review.googlesource.com/916661 Reviewed-by: Gwendal Grignou <gwendal@google.com> Commit-Queue: Gwendal Grignou <gwendal@google.com> Tested-by: Gwendal Grignou <gwendal@google.com> Trybot-Ready: Gwendal Grignou <gwendal@google.com> [rename] https://crrev.com/f22c57ab08f4915395887968b29a05a2c9fbd7b1/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r45.ebuild [add] https://crrev.com/f22c57ab08f4915395887968b29a05a2c9fbd7b1/app-laptop/laptop-mode-tools/files/0039-Fix-hdparm-udevadm-location.patch [modify] https://crrev.com/f22c57ab08f4915395887968b29a05a2c9fbd7b1/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild
,
Feb 13 2018
,
Feb 14 2018
Per #4, if this is an older issue not introduced in M64 I'm going to reject the merge request. Too late in the release to consider otherwise.
,
Feb 23 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by gwendal@chromium.org
, Feb 6 2018