New issue
Advanced search Search tips

Issue 809198 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

`gn analyze` idea: make it realize nothing needs to be done if pre- and post-patch generated ninja files are identical

Project Member Reported by thakis@chromium.org, Feb 5 2018

Issue description

See e.g. https://chromium-review.googlesource.com/c/chromium/src/+/899446 -- this change only changes compiler flags if is_chromeos is true and has no effect at all otherwise.

If the patch touches .gn files, `gn analyze` could generate ninja files with and without patch into a temp dir (running gn is fast), and then early-out if the output is identical. This would safely allow us to do nothing for things like:

- compiler changes on just one platform
- new files added on just one platform


(If the patch touches non-BUILD.gn files too, the current analyze behavior needs to run too of course; this is just a hand-wavy idea. But it feels like it could work and like it could save some amount of comp resources>
 
Cc: scottmg@chromium.org
Yup, I've talked about this idea w/ liaoyuke@ before, it seems safe and a good idea.
Components: Build
Owner: liaoyuke@chromium.org
Status: Assigned (was: Untriaged)
Thanks for filing the bug! Right now, I'm working on teaching Analyzer to understand DEPS file changes, which I think is of higher priorities, and when it's done, I do plan to explore this idea. I'll update the bug once I start.
Blocking: -555273
Labels: -OS-Linux -OS-Android -OS-Windows -OS-iOS -OS-Chrome -OS-Mac -OS-Fuchsia

Sign in to add a comment