`gn analyze` idea: make it realize nothing needs to be done if pre- and post-patch generated ninja files are identical |
||||
Issue descriptionSee e.g. https://chromium-review.googlesource.com/c/chromium/src/+/899446 -- this change only changes compiler flags if is_chromeos is true and has no effect at all otherwise. If the patch touches .gn files, `gn analyze` could generate ninja files with and without patch into a temp dir (running gn is fast), and then early-out if the output is identical. This would safely allow us to do nothing for things like: - compiler changes on just one platform - new files added on just one platform (If the patch touches non-BUILD.gn files too, the current analyze behavior needs to run too of course; this is just a hand-wavy idea. But it feels like it could work and like it could save some amount of comp resources>
,
Feb 5 2018
Yup, I've talked about this idea w/ liaoyuke@ before, it seems safe and a good idea.
,
Feb 5 2018
Thanks for filing the bug! Right now, I'm working on teaching Analyzer to understand DEPS file changes, which I think is of higher priorities, and when it's done, I do plan to explore this idea. I'll update the bug once I start.
,
May 17 2018
,
Aug 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scottmg@chromium.org
, Feb 5 2018