New issue
Advanced search Search tips

Issue 809192 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

gtest test runner on Android leaks temporary directory without --gs-test-artifacts-bucket flag

Reported by mcda...@amazon.com, Feb 5 2018

Issue description

Steps to reproduce the problem:
1. ./out/Default/bin/run_base_unittests -f "JniArray.BasicConversions" (test and test count do not matter)
2. adb shell ls /sdcard/
3. There will be an extra tmp-abc123 directory that didn't previously exist. 

What is the expected behavior?
All temporary directories created by the test run are deleted.

What went wrong?
A tmp directory is created on /sdcard/ but never deleted.

Did this work before? Yes Broke after 29acd73bc8956568a114918d5c9b3152ed67c41f

Chrome version: v65  Channel: dev
OS Version: N/A
Flash Version: Shockwave Flash 28.0 r0

This occurs because the NamedDeviceTemporaryDirectory for the test_artifacts_dir is created unconditionally but only conditionally deleted (if the --gs-test-artifacts-bucket flag is set).
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/4cb9c7f9f24da87fff4ffcd015f4d632d36db557

commit 4cb9c7f9f24da87fff4ffcd015f4d632d36db557
Author: David McAllister <mcdavid@amazon.com>
Date: Mon Feb 05 22:35:30 2018

Fix NamedDeviceTemporaryDirectory leak with contextlib_ext.Optional

NamedDeviceTemporaryDirectory creates its managed directory in its
__init__ method, but deletes it in __exit__. Since
contextlib_ext.Optional unconditionally calls __init__ but conditionally
calls __exit__, the directory will be leaked if its condition is False.
This fix moves the creation of the directory to __enter__ so that the
directory is only created if it will also be destroyed.

BUG= chromium:809192 

Change-Id: Ib1dced2fecf32ab343e8c4f53762f1797811a541
Reviewed-on: https://chromium-review.googlesource.com/902458
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/4cb9c7f9f24da87fff4ffcd015f4d632d36db557/devil/devil/android/device_temp_file.py

Comment 3 by mcda...@amazon.com, Feb 5 2018

Fix landed, this can be closed.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b186161a02c3b7a1c337825131aa1bdb2deb3349

commit b186161a02c3b7a1c337825131aa1bdb2deb3349
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Feb 06 01:30:37 2018

Roll src/third_party/catapult/ ef4265e56..6d0f862d8 (4 commits)

https://chromium.googlesource.com/catapult.git/+log/ef4265e56abb..6d0f862d8710

$ git log ef4265e56..6d0f862d8 --date=short --no-merges --format='%ad %ae %s'
2018-02-02 dtu [pinpoint] Remove _MAX_REPEAT_COUNT. Add Attempts one Change at a time.
2018-02-05 mcdavid Fix NamedDeviceTemporaryDirectory leak with contextlib_ext.Optional
2018-02-05 eakuefner [Telemetry] Simplify and test HtmlOutputFormatter
2018-02-05 eakuefner [Telemetry] Use ShouldAddValue to filter histograms

Created with:
  roll-dep src/third_party/catapult
BUG= 809192 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I52864e65189f7e09ceebcc9c59d45c7e50860925
Reviewed-on: https://chromium-review.googlesource.com/902960
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534570}
[modify] https://crrev.com/b186161a02c3b7a1c337825131aa1bdb2deb3349/DEPS

Status: Fixed (was: Unconfirmed)

Sign in to add a comment