PolicyTest.URLBlacklistClientRedirect in browser_tests failing on chromium.mac/Mac10.10 Tests |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tmartino@chromium.org PolicyTest.URLBlacklistClientRedirect in browser_tests failing on chromium.mac/Mac10.10 Tests Builders failed on: - Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests This test has been flaking very intermittently since Friday. IIRC it's happened on multiple builders as well, but I don't have any other failures in front of me.
,
Feb 6 2018
Yup; mine.
,
Feb 6 2018
Possible fix on try now:
https://chromium-review.googlesource.com/c/chromium/src/+/903239
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43b5c50b5d0aca15096b494ad9569f3f0430ebe3 commit 43b5c50b5d0aca15096b494ad9569f3f0430ebe3 Author: Doug Turner <dougt@chromium.org> Date: Tue Feb 06 16:30:49 2018 Fix flakey PolicyTest.URLBlacklistClientRedirect This test uses a client side redirect which causes two navigations. The first navigation loads the html document which has a meta refresh tag in it. The second navigation is caused by the redirect itself. The existing code would only wait for the *first* navigation to complete. On fast machines, this isn't a problem as the race would be usually won and the redirected page would be present when we reached the GetTitle check. On slower machines, it seems that this race is more frequently lost. This CL changes the test to wait for two navigations before continuing. Bug: 809187 Change-Id: If88bff4bcd8ff3cb5be23b54b9675c3edbe17983 Reviewed-on: https://chromium-review.googlesource.com/903239 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#534696} [modify] https://crrev.com/43b5c50b5d0aca15096b494ad9569f3f0430ebe3/chrome/browser/policy/policy_browsertest.cc
,
Feb 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tmartino@chromium.org
, Feb 5 2018Status: Assigned (was: Available)