📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/129cece1840000

Adding owners Charlie and Ned. Disabling this page.

Anddd it was removed in smoke testing: https://cs.chromium.org/chromium/src/tools/perf/benchmarks/system_health_smoke_test.py?rcl=f3f1d2bcb91428a084b3d84678a5d42a02eb55ad&l=72 :-(

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87cb1fa3a46caabc9a350bb96cfc70162b938cd4

commit 87cb1fa3a46caabc9a350bb96cfc70162b938cd4
Author: Annie Sullivan <sullivan@chromium.org>
Date: Mon Feb 05 20:51:26 2018

Disable failing tumblr page on Linux.

Bug:  809146 
Change-Id: I1bc0aefd5274d2fa5eebd67e6a95edbe228686e3
Tbr: nednguyen@google.com
Reviewed-on: https://chromium-review.googlesource.com/902404
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534490}
[modify] https://crrev.com/87cb1fa3a46caabc9a350bb96cfc70162b938cd4/tools/perf/expectations.config

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/129cece1840000

Harmonize infobars, part 1: modify element spacing/padding. by pkasting@chromium.org
chromium @ 0e7a30e1cdfa6a3561ff6539474fa2761accba94

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

If this is due to my commit, then it's a dupe.

Retrying a perf try job to see if this passes now.

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/167b37f6a40000

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/167b37f6a40000

Looks like this fails about 30% of the time.

Some error logs:
https://chrome-swarming.appspot.com/task?id=3ecbf70acf987d10&refresh=10&show_raw=1
https://chrome-swarming.appspot.com/task?id=3ecbf7129cc48c10&refresh=10&show_raw=1
https://chrome-swarming.appspot.com/task?id=3ecbf717da927110&refresh=10&show_raw=1
https://chrome-swarming.appspot.com/task?id=3ecbf13726998810&refresh=10&show_raw=1
https://chrome-swarming.appspot.com/task?id=3ecbf1385a5a3610&refresh=10&show_raw=1
https://chrome-swarming.appspot.com/task?id=3ecbf13ae8b7a110&refresh=10&show_raw=1


All show the same thing in the logs:
(ERROR) 2018-07-19 08:26:39,575 story_runner.ProcessError:100  Handleable error. Will try to restart shared state
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 125, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 310, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run
    self.RunPageInteractions(action_runner)
  File "/b/s/w/ir/tools/perf/page_sets/system_health/system_health_story.py", line 110, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/s/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 368, in _DidLoadDocument
    self._ViewMediaItem(action_runner, index)
  File "/b/s/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 466, in _ViewMediaItem
    action_runner.MouseClick(selector='#tumblr_lightbox_center_image')
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 596, in MouseClick
    self._RunAction(MouseClickAction(selector=selector))
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 62, in _RunAction
    action.RunAction(self._tab)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/mouse_click.py", line 35, in RunAction
    tab, code, selector=self._selector)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/page_action.py", line 130, in EvaluateCallbackWithElement
    return tab.EvaluateJavaScript(code)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 252, in EvaluateJavaScript
    return self._EvaluateJavaScript(expression, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 527, in _EvaluateJavaScript
    return self._runtime.Evaluate(expression, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 53, in Evaluate
    description=details.get('exception', {}).get('description'))
EvaluateException: UncaughtError:
Error: Cannot find element: using selector "#tumblr_lightbox_center_image"

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/169983fea40000

At Ned's advice, I updated my "enable" CL to also wait a bit for the lightbox to appear before attempting to click on it: https://chromium-review.googlesource.com/c/chromium/src/+/1143139

Kicked off the pinpoint job in #11 with this change.

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/169983fea40000

Now the test failed twice of 20 runs. Curiously, both failures were on the same bot:

https://chrome-swarming.appspot.com/task?id=3eccaa2e8a427110&refresh=10&show_raw=1

All screenshots show a keyring error on that bot. I think my CL fixes the issue with the tumblr click. Filed bug 865576 for keyring issues. Sending CL out for review.

Deleted: keyring-error.png 146 KB

	keyring-error.png 146 KB View Download

Actually I looked back to the logs in #10 and I had not checked the screenshots. There are keyring errors in all of them. Ned, any thoughts on what could be happening here?

#15: Annie, I think maybe you were just unlucky and pinpoint picked a swarming bot that which doesn't have keyring disabled. I think Dave found something similar today on pinpoint bots (issue https://bugs.chromium.org/p/chromium/issues/detail?id=773084#c21)

Re #16: I looked at the failures in #10, there are failing on build198-a7 and build199-a7 as well as build201-a7. Only 201-a7 was in both builds. So I think you're likely right that this is a bot issue. Adding those to the bug I filed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb38fa58352d573d20dd5fd8c66f6d9f2ea72275

commit bb38fa58352d573d20dd5fd8c66f6d9f2ea72275
Author: Annie Sullivan <sullivan@chromium.org>
Date: Fri Jul 20 00:01:10 2018

Re-enable browse:media:tumblr on system_health.common_desktop.

Adds a wait before attempting to click on the lightbox, which errors
out sometimes on Mac.

Bug:  809146 
Change-Id: I6f6287184ce4943fc508c9968552c9ac07233269
Reviewed-on: https://chromium-review.googlesource.com/1143139
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#576704}
[modify] https://crrev.com/bb38fa58352d573d20dd5fd8c66f6d9f2ea72275/tools/perf/expectations.config
[modify] https://crrev.com/bb38fa58352d573d20dd5fd8c66f6d9f2ea72275/tools/perf/page_sets/system_health/browsing_stories.py

My CL makes the v8 version of the test crash. I'm going to revert it.

The good news is that the test passed in all 4 runs since my re-enable. I'll create a CL to re-enable without the pause.

Also in bug 804324, johnw notes that passing tests also have the keyring issue. I think maybe it's a red herring?

After some offline discussion, I will at least wait on a bisect in bug 865887 before reverting my CL. If the cause is my CL, we will attempt to find an owner of the crash bug before reverting my CL.

Marking this fixed because the re-enable works everywhere. The v8 crash seems to be an intermittent flake unrelated to my CL.