pre-cq launcher is fail looping |
|||
Issue descriptionhttps://luci-milo.appspot.com/buildbot/chromeos/pre-cq-launcher/10856 Traceback (most recent call last): File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 229, in wrapped_functor return functor(*args, **kwargs) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2125, in PerformStage builder_run=self._run) File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 501, in AcquirePool if pool.AcquireChanges(gerrit_query, ready_fn, change_filter): File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 414, in AcquireChanges self, self.candidates, self.non_manifest_changes) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2055, in ProcessChanges self.ScreenChangeForPreCQ(change) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1385, in ScreenChangeForPreCQ configs_to_test = self.VerificationsForChange(change) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1341, in VerificationsForChange configs_to_test = self._ConfiguredVerificationsForChange(change) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1322, in _ConfiguredVerificationsForChange pre_cq_configs.sort() AttributeError: 'set' object has no attribute 'sort'
,
Feb 5 2018
Perhaps we weren't exceeding the pre-cq verification targets limit all this time... https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/stages/sync_stages.py?type=cs&q=_ConfiguredVerificationsForChange+file:%5Echromite/cbuildbot/stages/+package:%5Echromeos_public$&l=1320
,
Feb 5 2018
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/901956
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/79c64561b1ed5fbfb296bfcb7bfdee2f4e361f2a commit 79c64561b1ed5fbfb296bfcb7bfdee2f4e361f2a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Feb 05 18:05:29 2018 cbuildbot: Handle too many pre-cq configs properly in pre-cq-launcher. We were trying to sort a set, chocking whenever too many pre-cq configs were requested for a change. While there, make the unittest more behavioural. BUG= chromium:809108 TEST=unittest; restart pre-cq launcher and watch it happy. Change-Id: Ie89f06375ebf5bdbc1745faa5d4cc91edc655529 Reviewed-on: https://chromium-review.googlesource.com/901956 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> [modify] https://crrev.com/79c64561b1ed5fbfb296bfcb7bfdee2f4e361f2a/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/79c64561b1ed5fbfb296bfcb7bfdee2f4e361f2a/cbuildbot/stages/sync_stages.py
,
Feb 5 2018
Restarted pre-cq-launcher to pick up #4.
,
Feb 5 2018
Believed fixed, don't think we need a chase followup. Alerting worked well here and the problem was resolved quickly. +jclinton for context on CI type fires
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/990a407a38e0d01759ecd43371a8182ae4516d62 commit 990a407a38e0d01759ecd43371a8182ae4516d62 Author: Ningning Xia <nxia@google.com> Date: Tue Feb 06 12:55:57 2018 sync_stages: fix ExceedUnionPreCQLimitException docstring. BUG= chromium:809108 TEST=None Change-Id: I1eec661b7793e28705ee82d0284a1db939a3e11f Reviewed-on: https://chromium-review.googlesource.com/901960 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/990a407a38e0d01759ecd43371a8182ae4516d62/cbuildbot/stages/sync_stages.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by pho...@chromium.org
, Feb 5 2018