New issue
Advanced search Search tips

Issue 809069 link

Starred by 3 users
Status: WontFix
Owner:
sahel@chromium.org
Closed: Feb 2018
Cc:
dnicoara@chromium.org
kenrb@chromium.org
wjmaclean@chromium.org
pnangunoori@chromium.org
dcasta...@chromium.org
nyerramilli@chromium.org
sahel@chromium.org
liber...@chromium.org
mcnee@chromium.org
ligim...@chromium.org
lethalantidote@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot fling in an OOPIF

Project Member Reported by mcnee@chromium.org, Feb 5 2018 
Chrome Version: 66.0.3341.0

What steps will reproduce the problem?
(1) Run chrome with --site-per-process
(2) Visit http://csreis.github.io/tests/cross-site-iframe-simple.html
(3) Scroll the iframe and end the gesture with a fling

What is the expected result?
The fling should cause additional scrolling.

What happens instead?
Scrolling stops immediately.

Initially assigning to sahel@ as I'm guessing that this could be related to the recent work to move fling into the browser.

Comment 1 by mcnee@chromium.org, Feb 5 2018 

Yep. I locally reverted https://chromium.googlesource.com/chromium/src/+/ef3f05dd13ef8e10c3084e216472622912cdb1a1 and flinging worked again on touchscreen.

Comment 2 by sahel@chromium.org, Feb 5 2018

Status: Started (was: Assigned)

Comment 3 by sahel@chromium.org, Feb 7 2018

Cc: dcasta...@chromium.org sahel@chromium.org ligim...@chromium.org dnicoara@chromium.org lethalantidote@chromium.org nyerramilli@chromium.org pnangunoori@chromium.org liber...@chromium.org
 Issue 809169  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10bc4d47f4568374d5ff1a1ec211bf14c965852d

commit 10bc4d47f4568374d5ff1a1ec211bf14c965852d
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Feb 07 22:16:36 2018

Browser side fling works properly with oopif.

The fling progress must get called on begin frame in rwhv_child_frame.
rwhv_android and rwhv_aura are already calling ProgressFling on begin
frame, I missed to do the same thing in rwhv_child_frame and it was
breaking the fling on a oopif.

Bug:  809069 
Test: SitePerProcessBrowserTest.GestureFlingStart
Change-Id: I4319f5cc9fe5863331f8babf4cde3a08d773f106
Reviewed-on: https://chromium-review.googlesource.com/901959
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535162}
[modify] https://crrev.com/10bc4d47f4568374d5ff1a1ec211bf14c965852d/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/10bc4d47f4568374d5ff1a1ec211bf14c965852d/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/10bc4d47f4568374d5ff1a1ec211bf14c965852d/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/10bc4d47f4568374d5ff1a1ec211bf14c965852d/testing/buildbot/filters/viz.content_browsertests.filter

Comment 5 by sahel@chromium.org, Feb 8 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1822bf3805fceac699aa0d468c8a62d841d213f

commit b1822bf3805fceac699aa0d468c8a62d841d213f
Author: Sahel Sharify <sahel@chromium.org>
Date: Fri Feb 09 14:50:34 2018

Revert touchscreen browser side fling cls in stack order to avoid conflicts.

Revert "Touchscreen fling handled on browser."
This reverts commit ef3f05dd13ef8e10c3084e216472622912cdb1a1.

Revert "TouchStart should be uncancelable during an active touchscreen fling."
This reverts commit 7460a67e494251d321579e1b4fc6c8298408ad7c.

Revert "Fling controller notifies the client after fling cancellation."
This reverts commit 7b1d8bcc2db94ce1acf6cb267f2df87c61d9d4c2.

Revert "Browser side fling works properly with oopif."
This reverts commit 10bc4d47f4568374d5ff1a1ec211bf14c965852d.

The cls are reverted since browser side touchscreen fling breaks
android webview's synchronous input animation.

TBR=alexmos@chromium.org

Bug: 808929,  249063 ,  809069 ,  808587 
Change-Id: I35e1fd34317c0979cf05780a43426c2d76e85578
Reviewed-on: https://chromium-review.googlesource.com/909699
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535708}
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/gesture_event_queue.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/input_router.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/legacy_input_router_impl.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/legacy_input_router_impl.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/passthrough_touch_event_queue.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/passthrough_touch_event_queue.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/common/input/gesture_event_stream_validator.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/content/common/input/input_event_stream_validator.h
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/b1822bf3805fceac699aa0d468c8a62d841d213f/ui/events/blink/input_handler_proxy_unittest.cc

Comment 7 by mar...@mwiacek.com, Feb 12 2018 

1. we have revert and it cannot be fixed in this situation 

2. related: https://bugs.chromium.org/p/chromium/issues/detail?id=811248 ?

Comment 8 by creis@chromium.org, Feb 22 2018

Status: Started (was: Fixed)
sahel@: This should be re-opened after the revert in r535708, correct?  Is there a bug number for the Android Webview issue you mention?  And is there another way to fix this?

Comment 9 by sahel@chromium.org, Feb 22 2018

Status: WontFix (was: Started)
r535708 reverths both "Touchscreen fling handled on browser." which is the cause of the issue and "Browser side fling works properly with oopif." which is the fix for the issue.

Since the original patch is reverted the fix is not needed anymore.

Comment 10 by creis@chromium.org, Feb 22 2018 

Ah, thanks!  That clarifies it.
►

Sign in to add a comment