New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809067 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1
Hotlist-2
Hotlist-3


Sign in to add a comment

Site isolation: Figure out where UpdateResizeParams should live

Project Member Reported by fsam...@chromium.org, Feb 5 2018

Issue description

As of this patch, https://chromium-review.googlesource.com/c/chromium/src/+/900315, UpdateResizeParams lives on FrameConnectorDelegate. This is strange because FrameConnectorDelegate is meant to be an intermediary between RWHVChildFrame and CrossProcessFrameConnector. RWHVCF never calls UpdateResizeParams.

UpdateResizeParams lives on FrameConnectorDelegate for testability purposes. Moving it to CrossProcessFrameConnector really complicates unit tests because a whole lot more stuff needs to be brought into the test (RenderFrameProxyHost). Instead, I think UpdateResizeParams should be a public non-virtual method on RWHVChildFrame called by CrossProcessFrameConnector.

There are a bunch of other sizing methods that should probably move there too.

 
Cc: dcheng@chromium.org

Comment 2 by kenrb@chromium.org, Feb 5 2018

Cc: -kenrb@chromium.org
Owner: kenrb@chromium.org
Status: Assigned (was: Untriaged)
Assigning to myself, but I have a few other higher priority items right now, so if someone is inclined to steal it then feel free.

Sign in to add a comment