New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809046 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

CHECK failure: IsValueInRangeForNumericType<Dst>(value) in safe_conversions.h

Project Member Reported by ClusterFuzz, Feb 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5968506705936384

Fuzzer: libFuzzer_rtp_packet_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  IsValueInRangeForNumericType<Dst>(value) in safe_conversions.h
  rtc::FatalMessage::~FatalMessage
  unsigned short rtc::dchecked_cast<unsigned short, unsigned long>
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=501918:501942

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5968506705936384

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 5 2018

Cc: danilchap@webrtc.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target by danilchap@webrtc.org - https://webrtc.googlesource.com/src/webrtc/+/bb11e12079726753f08094ed9dca8dc52c98dfea

Remove RtpPacketToSend::GetHeader as almost unused. by danilchap@webrtc.org - https://webrtc.googlesource.com/src/webrtc/+/1f4668043e639759ad998c0849c5e6e242008e1d

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Components: Blink>WebRTC>Network
EstimatedDays: 1
Labels: -Pri-1 Pri-3
Owner: danilchap@chromium.org
Status: Started (was: Untriaged)
To trigger incoming packet has to be > 64k, but packets larger than > 1500 are discarded earlier in the pipeline. Thus reducing priority.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c2dd59c25da7532df4b4e75d853510a4a11724bf

commit c2dd59c25da7532df4b4e75d853510a4a11724bf
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Tue Feb 06 11:30:08 2018

Skip oversized rtp header extension when parsing Rtp Packet.

Rtp Packets in webrtc expected to be less that 1500,
i.e. way less that 2^16 bytes for extensions block.
This CL explicitly discards longer extension.

Bug:  chromium:809046 
Change-Id: Ibed33b51bafc3fd4804ec135f66110c6d2796734
Reviewed-on: https://webrtc-review.googlesource.com/48061
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21910}
[modify] https://crrev.com/c2dd59c25da7532df4b4e75d853510a4a11724bf/modules/rtp_rtcp/source/rtp_packet.cc
[add] https://crrev.com/c2dd59c25da7532df4b4e75d853510a4a11724bf/test/fuzzers/corpora/rtp-corpus/rtp-5

Project Member

Comment 4 by ClusterFuzz, Feb 7 2018

ClusterFuzz has detected this issue as fixed in range 534723:534737.

Detailed report: https://clusterfuzz.com/testcase?key=5968506705936384

Fuzzer: libFuzzer_rtp_packet_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  IsValueInRangeForNumericType<Dst>(value) in safe_conversions.h
  rtc::FatalMessage::~FatalMessage
  unsigned short rtc::dchecked_cast<unsigned short, unsigned long>
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=501918:501942
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=534723:534737

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5968506705936384

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Feb 7 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5968506705936384 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment