New issue
Advanced search Search tips

Issue 809045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug



Sign in to add a comment

win_more_configs bot is slow

Project Member Reported by oprypin@chromium.org, Feb 5 2018

Issue description

Previously win_more_configs (a bot which compiles 8 different configurations) was flaky.
Example failure: https://build.chromium.org/p/tryserver.webrtc/builders/win_more_configs/builds/4301
This happened because ninja's caching is buggy on Windows, and all those different configurations were built in the same directory. 

Solution: Build each config in a different out dir.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/883365
This worked out well in terms of flakiness, but now there is a new problem: it's much slower.
Apparently, rebuilding with a different config is typically faster than rebuilding with modified source code. We definitely don't want to go back to the flaky compilation, but if win_more_configs takes 50 minutes on average when most bots are under 25 minutes, that's a problem.

Other _more_configs bots also became slower, by the way, and they didn't even necessarily have to change to using different out dirs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9fed4ed422a390067bd15045485eb00cd6c8b997

commit 9fed4ed422a390067bd15045485eb00cd6c8b997
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Feb 05 15:46:17 2018

WebRTC: Build additional configurations two at a time

to reduce the run time of *_more_configs bots.

Failures specific to those configurations are so rare that checking more
than one of them at once should not harm discoverability of failures.

Bug:  chromium:809045 
Change-Id: I461d4b4410a983afb8b7e9fa1ad59a37589ca7b6
Reviewed-on: https://chromium-review.googlesource.com/901603
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_win_more_configs.json
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.py
[modify] https://crrev.com/9fed4ed422a390067bd15045485eb00cd6c8b997/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Win__more_configs_.json

Status: Fixed (was: Assigned)
win_more_configs is still the slowest but only slightly above other bots.

Sign in to add a comment