New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809035 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 809027



Sign in to add a comment

Convert password_sync_util to talk to Identity Service client library

Project Member Reported by blundell@chromium.org, Feb 5 2018

Issue description

Has getter that returns user’s authenticated email address; should be straight to convert to get this info via IdentityManager.
 
Blocking: 809027
Components: Internals>Services>Identity
Status: Available (was: Untriaged)
Owner: jdmuys@chromium.org
Status: Assigned (was: Available)
These are free functions which get the SigninManager as a parameter. We need to provide new function that take an IdentityManager instead. So here is the plan:

1 (done)- Add dual functions taking IdentityManager as a parameter in the .h file.
2 (done)- Implement those function in the .cpp file
3 (done)- Find all the includes of the .h file. There are 4 of them
4 (tbd) - convert those 4 files to use the new dual functions
5 (tbd) - test. I need to find out how.
6 (tbd) - remove the old functions

the 4 client files:
components/password_manager/sync/browser/sync_credentials_filter.cc
components/password_manager/sync/browser/password_sync_util_unittest.cc
chrome/browser/ui/passwords/password_manager_presenter.cc
chrome/browser/password_manager/chrome_password_manager_client.cc

the sync code containing these source files has been removed, and thus these files do not exist any more.

see https://chromium-review.googlesource.com/c/chromium/src/+/1252583

Sign in to add a comment