New issue
Advanced search Search tips

Issue 809030 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544
issue 809031
issue 809036



Sign in to add a comment

Determine whether/how to port SupervisedUserSigninManagerWrapper to the Identity Service world

Project Member Reported by blundell@chromium.org, Feb 5 2018

Issue description

Need to determine our strategy for dealing with this interface, which intertangles a dependency on //components/signin with the notion of supervised users.
 
Blocking: 809031
Blocking: 809036

Comment 3 by treib@chromium.org, Apr 16 2018

Cc: treib@chromium.org
We can probably get rid of Supervised User support in Sync very soon, so it shouldn't be necessary to port this interface.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8455d78181378b9ffa537175a9c5460109883b02

commit 8455d78181378b9ffa537175a9c5460109883b02
Author: Marc Treib <treib@chromium.org>
Date: Wed Apr 18 09:32:13 2018

Sync: Remove SupervisedUserSigninManagerWrapper

This will effectively turn off Sync for Supervised Users.
Supervised Users have been deprecated, and it's not possible anymore for
custodians to add or update any restrictions, which was to main reason
for requiring Sync.

Bug:  829304 ,  809030 
Change-Id: I510cc9da1aa26147e890b94e17dcb147d5ca9034
Reviewed-on: https://chromium-review.googlesource.com/997654
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551619}
[modify] https://crrev.com/8455d78181378b9ffa537175a9c5460109883b02/chrome/browser/BUILD.gn
[modify] https://crrev.com/8455d78181378b9ffa537175a9c5460109883b02/chrome/browser/sync/profile_sync_service_factory.cc
[delete] https://crrev.com/f4b46947717b0127d9082fc3295aeca47ba714dc/chrome/browser/sync/supervised_user_signin_manager_wrapper.cc
[delete] https://crrev.com/f4b46947717b0127d9082fc3295aeca47ba714dc/chrome/browser/sync/supervised_user_signin_manager_wrapper.h

Comment 5 by treib@chromium.org, Apr 18 2018

Cc: -treib@chromium.org
Owner: treib@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment