The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c3e8642532f753ab688445c7093012dba3f8f1

commit 31c3e8642532f753ab688445c7093012dba3f8f1
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Feb 05 21:29:10 2018

[vr] Add not-web-exposed media feature for immersive mode.

With this change, I've added a media feature that returns true when
in immersive mode (eg, in VR). I've added extra plumbing to ensure that
this new feature is not web exposed.

More info on media features here:
https://www.w3.org/TR/css3-mediaqueries/#media1

The plumbing for this particular feature is very close to the plumbing
for -webkit-transform-3d.

I've also changed the "page popups suppressed" setting (which was only
ever true in immersive mode) to be named immersive, accordingly.
However, the uses of the immersive mode setting for suppressing page
popups are meant to be temporary, so I've added comments referencing
the bug that explains the removals.

Bug:  809021 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11
Reviewed-on: https://chromium-review.googlesource.com/901484
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534497}
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/content/public/common/web_preferences.cc
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/content/public/common/web_preferences.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/content/renderer/render_view_impl.cc
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaQueryExp.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValues.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValuesCached.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/MediaValuesDynamic.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/media_feature_names.json5
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/parser/CSS.proto
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/css/parser/MediaQueryParser.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/core/page/ChromeClientImplTest.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/31c3e8642532f753ab688445c7093012dba3f8f1/third_party/WebKit/public/web/WebSettings.h

Throwing this over the fence now that the mq is ready.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f68908b0a84e94689e03f94980fd2c197fc50872

commit f68908b0a84e94689e03f94980fd2c197fc50872
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Feb 06 18:23:51 2018

Revert "[vr] Add not-web-exposed media feature for immersive mode."

This reverts commit 31c3e8642532f753ab688445c7093012dba3f8f1.

Reason for revert: looks like there are bugs in the serialization code. Reverting while I investigate.

Original change's description:
> [vr] Add not-web-exposed media feature for immersive mode.
> 
> With this change, I've added a media feature that returns true when
> in immersive mode (eg, in VR). I've added extra plumbing to ensure that
> this new feature is not web exposed.
> 
> More info on media features here:
> https://www.w3.org/TR/css3-mediaqueries/#media1
> 
> The plumbing for this particular feature is very close to the plumbing
> for -webkit-transform-3d.
> 
> I've also changed the "page popups suppressed" setting (which was only
> ever true in immersive mode) to be named immersive, accordingly.
> However, the uses of the immersive mode setting for suppressing page
> popups are meant to be temporary, so I've added comments referencing
> the bug that explains the removals.
> 
> Bug:  809021 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11
> Reviewed-on: https://chromium-review.googlesource.com/901484
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534497}

TBR=avi@chromium.org,rbyers@chromium.org,vollick@chromium.org,kenrb@chromium.org

Change-Id: Ieab8e1124aa92e98aeceb68504a16695024b08f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  809021 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/905062
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534725}
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/content/public/common/web_preferences.cc
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/content/public/common/web_preferences.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/content/renderer/render_view_impl.cc
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaQueryExp.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValues.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValuesCached.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/MediaValuesDynamic.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/media_feature_names.json5
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/parser/CSS.proto
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/css/parser/MediaQueryParser.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/core/page/ChromeClientImplTest.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/f68908b0a84e94689e03f94980fd2c197fc50872/third_party/WebKit/public/web/WebSettings.h

..and taking it back because the mq isn't ready :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeca1d8fa225e3bcfe88eadd9290ba64e781153a

commit eeca1d8fa225e3bcfe88eadd9290ba64e781153a
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Feb 07 02:43:42 2018

Reland "[vr] Add not-web-exposed media feature for immersive mode."

This is a reland of 31c3e8642532f753ab688445c7093012dba3f8f1.

Original change's description:
> [vr] Add not-web-exposed media feature for immersive mode.
>
> With this change, I've added a media feature that returns true when
> in immersive mode (eg, in VR). I've added extra plumbing to ensure that
> this new feature is not web exposed.
>
> More info on media features here:
> https://www.w3.org/TR/css3-mediaqueries/#media1
>
> The plumbing for this particular feature is very close to the plumbing
> for -webkit-transform-3d.
>
> I've also changed the "page popups suppressed" setting (which was only
> ever true in immersive mode) to be named immersive, accordingly.
> However, the uses of the immersive mode setting for suppressing page
> popups are meant to be temporary, so I've added comments referencing
> the bug that explains the removals.
>
> Bug:  809021 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11
> Reviewed-on: https://chromium-review.googlesource.com/901484
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534497}

TBR=avi@chromium.org

Bug:  809021 
Change-Id: I23ec9a7506a5fa8904f716a3c43bb4ad5b5bbe2c
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/905782
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534891}
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/content/public/common/web_preferences.cc
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/content/public/common/web_preferences.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/content/renderer/render_view_impl.cc
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaQueryExp.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValues.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValuesCached.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/MediaValuesDynamic.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/media_feature_names.json5
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/parser/CSS.proto
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/parser/CSSProtoConverter.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/css/parser/MediaQueryParser.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/frame/Settings.json5
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/core/page/ChromeClientImplTest.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/eeca1d8fa225e3bcfe88eadd9290ba64e781153a/third_party/WebKit/public/web/WebSettings.h

Here are screenshots from patchset 1 of crrev.com/c/993396, which starts the visual changes by shortening the timeline and button panel. Note that these are taken from a laptop, not a VR headset (Chrome was set to force immersive mode and there was a hack to work around crbug.com/828510)

Deleted: crrev.993396.patchset1.400px.png 87.9 KB

	crrev.993396.patchset1.400px.png 87.9 KB View Download

Deleted: crrev.993396.patchset1.1000px.png 299 KB

	crrev.993396.patchset1.1000px.png 299 KB View Download

Deleted: crrev.993396.patchset1.fullscreen.png 435 KB

	crrev.993396.patchset1.fullscreen.png 435 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff9504a083bf4d0025dd079c174a54065188fae

commit 5ff9504a083bf4d0025dd079c174a54065188fae
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Apr 04 16:35:14 2018

Add CSS to media controls to shrink the timeline and button panel in VR

This CL makes use of the new "immersive" media query to add styling for
the new media controls in VR mode. Due to a bug in how the "immersive"
media query works, the changes here are not visible yet.

Bug:  809021 
Change-Id: I3737a3e1f6ca27d5111cf1d7e4b5b2ae221ee97f
Reviewed-on: https://chromium-review.googlesource.com/993396
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548090}
[modify] https://crrev.com/5ff9504a083bf4d0025dd079c174a54065188fae/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Attached is a screenshot from patchset 1 of crrev.com/c/1000403

Deleted: crrev.1000403.patchset1.png 349 KB

	crrev.1000403.patchset1.png 349 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8280c4c838badf64d9d7781dce11005094cae41

commit d8280c4c838badf64d9d7781dce11005094cae41
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Apr 09 19:35:21 2018

Update px values based on dmm to px conversion

This CL updates the modern media controls VR CSS to have the correct
pixel values based on the 0.66875 conversion factor.

Bug:  809021 
Change-Id: Icc7cfbd4b53b9af8cfa3707a21e8c36b278b2872
Reviewed-on: https://chromium-review.googlesource.com/999734
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549243}
[modify] https://crrev.com/d8280c4c838badf64d9d7781dce11005094cae41/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a1b52d1f411a59d021641d9d37eea7451330471

commit 2a1b52d1f411a59d021641d9d37eea7451330471
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Apr 10 02:00:12 2018

More CSS changes for VR with modern media controls

This CL adds more changes from the VR spec, mostly sizing, padding, and
margin changes.

What this CL does NOT cover:
1) Changes to the loading panel to match the different size/positioning
   of the overlay play button and timeline
2) Hover states on the buttons
3) Newly sized scrim

Bug:  809021 
Change-Id: Ibeb226e1801fbb695836038d779b30d359d24682
Reviewed-on: https://chromium-review.googlesource.com/1000403
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549374}
[modify] https://crrev.com/2a1b52d1f411a59d021641d9d37eea7451330471/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1baf9ec2968d96b543823fc67d89e9e2d2fbb0b

commit f1baf9ec2968d96b543823fc67d89e9e2d2fbb0b
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Apr 10 18:00:15 2018

Add hover highlighting for VR on modern media controls

This CL adds hover CSS rules to show a highlight when the media control
buttons are hovered.

Bug:  809021 ,  827568 
Change-Id: I69dfc0d5571efc39226f0e1da30adc211825a402
Reviewed-on: https://chromium-review.googlesource.com/1004119
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549585}
[modify] https://crrev.com/f1baf9ec2968d96b543823fc67d89e9e2d2fbb0b/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d14ffebf5c4e7a52d709156074ddde3aa78f758

commit 0d14ffebf5c4e7a52d709156074ddde3aa78f758
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Apr 17 19:38:32 2018

Use larger scrim for VR with modern media controls

Bug:  809021 
Change-Id: Ia8adffa5011fa6e2ae1d1aeef727f407eb9ccb2d
Reviewed-on: https://chromium-review.googlesource.com/1014721
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551439}
[add] https://crrev.com/0d14ffebf5c4e7a52d709156074ddde3aa78f758/third_party/blink/renderer/modules/media_controls/resources/default_100_percent/modern/vr_gradient_bg.png
[add] https://crrev.com/0d14ffebf5c4e7a52d709156074ddde3aa78f758/third_party/blink/renderer/modules/media_controls/resources/default_200_percent/modern/vr_gradient_bg.png
[modify] https://crrev.com/0d14ffebf5c4e7a52d709156074ddde3aa78f758/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Merge request for the CL in comment 23

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please confirm the fix works in canary

Just confirmed it. Thanks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d0ce5bdbff9a81208257a3e4b0a43f3957a6e7

commit 38d0ce5bdbff9a81208257a3e4b0a43f3957a6e7
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Apr 25 21:45:50 2018

Use larger scrim for VR with modern media controls

Bug:  809021 
Change-Id: Ia8adffa5011fa6e2ae1d1aeef727f407eb9ccb2d
Reviewed-on: https://chromium-review.googlesource.com/1014721
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551439}(cherry picked from commit 0d14ffebf5c4e7a52d709156074ddde3aa78f758)
Reviewed-on: https://chromium-review.googlesource.com/1028692
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#312}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[add] https://crrev.com/38d0ce5bdbff9a81208257a3e4b0a43f3957a6e7/third_party/blink/renderer/modules/media_controls/resources/default_100_percent/modern/vr_gradient_bg.png
[add] https://crrev.com/38d0ce5bdbff9a81208257a3e4b0a43f3957a6e7/third_party/blink/renderer/modules/media_controls/resources/default_200_percent/modern/vr_gradient_bg.png
[modify] https://crrev.com/38d0ce5bdbff9a81208257a3e4b0a43f3957a6e7/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

should this be marked as fixed now that it's been merged?

@dougman : now that this is merged, we should give it a go on beta. it looks like it's been merged for while, so recent beta should be good to go.

just want to make sure we cover this since we previously removed blocking marker for 808711 (cinema mode launch, which we ticked as Launch-Test=yes)

Initial pass looks good.  Handing off to @dbbrooks for Test Plan and test pass.

Looks good on 67.0.3396.49. Test plan complete. Test cases have been added to the "Cinema mode test plan".

Issue 642904 has been merged into this issue.