Username not saved when generating a password |
||||
Issue descriptionChrome Version: 66.0.3340.0 OS: macOS What steps will reproduce the problem? (1) Open https://rsolomakhin.github.io/autofill/ (2) Enter a username (in the Name/Password section) (3) Right-click password field and generate a password What is the expected result? The username and (generated) password are saved. What happens instead? The username isn't saved. Could you take a look? Thanks!
,
Feb 13 2018
,
Jun 12 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd commit fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Tue Jun 12 12:41:40 2018 [Password Generation] Presave generated password with the captured username A generated password and a captured username should be presaved once a user accepts a password generated by Chrome. If there is an entry with the captured usernmae in the store, then Chrome presaves only password (the username is empty). Before this CL, Chrome always presaved only password. This CL also ensures that a presaved entry is updated when the username value has been changed by user. Bug: 809019 Change-Id: I1f36f23d8ba12f09617b89791ce10a467f8dfa23 Reviewed-on: https://chromium-review.googlesource.com/1092745 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#566390} [modify] https://crrev.com/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd/components/password_manager/core/browser/password_form_manager.cc [modify] https://crrev.com/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/fa6cd8ef17f708c6fd9853ada31ebe1e0e173bfd/components/password_manager/core/browser/password_manager_unittest.cc
,
Aug 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by maxwalker@chromium.org
, Feb 5 2018