New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809016 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Chrome: Crash Report - v8::base::TimeTicks::HighResolutionNow

Project Member Reported by cr...@system.gserviceaccount.com, Feb 5 2018

Issue description

reporter:kkaluri@google.com

Magic Signature: v8::base::TimeTicks::HighResolutionNow

Crash link: https://crash.corp.google.com//browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D'v8%3A%3Abase%3A%3ATimeTicks%3A%3AHighResolutionNow'%20AND%20expanded_custom_data.ChromeCrashProto.channel%3D'canary'%20AND%20product.name%3D'Chrome'%20AND%20ReportID%3D'8e4885f437847a34'#3

-------------------------------------------------------------------------------
Sample Report
-------------------------------------------------------------------------------
Product name: Chrome
Magic Signature : v8::base::TimeTicks::HighResolutionNow
Product Version: 66.0.3339.1
Process type: utility
Report ID: 8e4885f437847a34
Report Url: https://crash.corp.google.com/8e4885f437847a34
Report Time: 2018-02-05T04:29:39-08:00
Upload Time: 2018-02-05T04:29:41.392-08:00
Uptime: 0 ms
CumulativeProductUptime: 0 ms
OS Name: Windows NT
OS Version: 6.1.7601 17651
CPU Architecture: x86
CPU Info: AuthenticAMD family 16 model 5 stepping 3

-------------------------------------------------------------------------------
Crashing thread: Thread index: 9. Stack Quality: 77%. Thread id: 4896.
-------------------------------------------------------------------------------
0x00000000 
0x10770605 (chrome_child.dll - logging.cc: 56)	v8::base::`anonymous namespace'::DefaultDcheckHandler
0x10772448 (chrome_child.dll - time.cc: 462)	v8::base::TimeTicks::HighResolutionNow()
0x0fa784b1 (chrome_child.dll - elapsed-timer.h: 25)	v8::base::ElapsedTimer::Start()
0x0fe247f5 (chrome_child.dll - log.cc: 1780)	v8::internal::Logger::SetUp(v8::internal::Isolate *)
0x0fe0ca7b (chrome_child.dll - isolate.cc: 3003)	v8::internal::Isolate::Init(v8::internal::StartupDeserializer *)
0x0ffd3764 (chrome_child.dll - snapshot-common.cc: 52)	v8::internal::Snapshot::Initialize(v8::internal::Isolate *)
0x0fa9745e (chrome_child.dll - api.cc: 8407)	v8::IsolateNewImpl(v8::internal::Isolate *,v8::Isolate::CreateParams const &)
0x122d9ddc (chrome_child.dll - isolate_holder.cc: 75)	gin::IsolateHolder::IsolateHolder(scoped_refptr<base::SingleThreadTaskRunner>,gin::IsolateHolder::AccessMode,gin::IsolateHolder::AllowAtomicsWaitMode,gin::IsolateHolder::IsolateCreationMode)
0x122d9c7b (chrome_child.dll - isolate_holder.cc: 41)	gin::IsolateHolder::IsolateHolder(scoped_refptr<base::SingleThreadTaskRunner>,gin::IsolateHolder::AccessMode)
0x125b2059 (chrome_child.dll - proxy_resolver_v8.cc: 394)	net::`anonymous namespace'::SharedIsolateFactory::GetSharedIsolate
0x125b19fc (chrome_child.dll - proxy_resolver_v8.cc: 874)	net::ProxyResolverV8::Create(scoped_refptr<net::ProxyResolverScriptData> const &,net::ProxyResolverV8::JSBindings *,std::unique_ptr<net::ProxyResolverV8,std::default_delete<net::ProxyResolverV8> > *)
0x125af4ac (chrome_child.dll - proxy_resolver_v8_tracing.cc: 573)	net::`anonymous namespace'::Job::ExecuteProxyResolver
0x125af25d (chrome_child.dll - proxy_resolver_v8_tracing.cc: 533)	net::`anonymous namespace'::Job::ExecuteBlocking
0x12123656 (chrome_child.dll - bind_internal.h: 350)	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::`anonymous namespace'::ChannelAssociatedGroupController::*)(void),scoped_refptr<IPC::`anonymous namespace'::ChannelAssociatedGroupController> >,void __cdecl(void)>::Run
0x10180f0c (chrome_child.dll - task_annotator.cc: 55)	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x10140f46 (chrome_child.dll - message_loop.cc: 399)	base::MessageLoop::RunTask(base::PendingTask *)
0x1014137c (chrome_child.dll - message_loop.cc: 411)	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x101416b8 (chrome_child.dll - message_loop.cc: 455)	base::MessageLoop::DoWork()
0x1019b884 (chrome_child.dll - message_pump_default.cc: 37)	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x10140733 (chrome_child.dll - message_loop.cc: 350)	base::MessageLoop::Run(bool)
0x1012f0b3 (chrome_child.dll - run_loop.cc: 133)	base::RunLoop::Run()
0x10150f41 (chrome_child.dll - thread.cc: 255)	base::Thread::Run(base::RunLoop *)
0x1015120e (chrome_child.dll - thread.cc: 338)	base::Thread::ThreadMain()
0x1013dbab (chrome_child.dll - platform_thread_win.cc: 91)	base::`anonymous namespace'::ThreadFunc
0x76033399 (KERNEL32.dll + 0x00013399)	BaseThreadInitThunk
0x77669ef1 (ntdll.dll + 0x00039ef1)	__RtlUserThreadStart
0x77669ec4 (ntdll.dll + 0x00039ec4)	_RtlUserThreadStart

 
Cc: kkaluri@chromium.org
Labels: TE-CrashTriage M-66
Owner: adamk@chromium.org
Status: Assigned (was: Untriaged)
Link to the list of the builds:
===============================
https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27v8%3A%3Abase%3A%3ATimeTicks%3A%3AHighResolutionNow%27%20AND%20expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20product.name%3D%27Chrome%27

66.0.3340.1	0.98%	2	
66.0.3339.1	30.88%	63	
66.0.3338.1	67.16%	137	
63.0.3220.0	0.98%	2	


Assigning it to this week v8 stability sheriff for help in further triaging

Comment 2 by adamk@chromium.org, Feb 5 2018

Cc: hpayer@chromium.org adamk@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>Runtime
Owner: gab@chromium.org
This is hitting a recently-added DCHECK in 954146a5cf923cfa0462f22d4525fbb81b96d761. Assigning to the gab@, please take a look.

Comment 3 by ajha@chromium.org, Feb 6 2018

Labels: Hotlist-Dcheck-Albatross
There is one more magic signature variant seen on Asan canary with Dcheck enabled '[Assert] `anonymous namespace'::V8DcheckCallbackHandler' spiked in recent Asan canary since 66.0.3338.1.


Link to the list of the builds:
===============================
https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.ptype%3D%27extension%27%20AND%20expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAssert%5D%20%60anonymous%20namespace%5C%27%3A%3AV8DcheckCallbackHandler%27%20AND%20product.name%3D%27Chrome%27#productversion:1000

Comment 4 by gab@chromium.org, Feb 6 2018

Status: Started (was: Assigned)

Comment 5 by gab@chromium.org, Feb 6 2018

Labels: -Restrict-View-EditIssue
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7758dfa0238ea777732d143ff0f5b046ed12e98

commit f7758dfa0238ea777732d143ff0f5b046ed12e98
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Feb 06 21:23:59 2018

Log error instead of DCHECK in absence of high resolution ticks clock.

Turns out this path is used in the wild for logs and counters.

We may eventually want to split TimedHistograms based on low resolution
clocks to avoid polluting metrics but for now just make it a warning
to raise awereness when debugging in such an environment.

R=hpayer@chromium.org

Bug:  chromium:809016 
Change-Id: I5f2dd511d5fce730256979d58212468f08a2d680
Reviewed-on: https://chromium-review.googlesource.com/904045
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51130}
[modify] https://crrev.com/f7758dfa0238ea777732d143ff0f5b046ed12e98/src/base/platform/time.cc

Comment 7 by ajha@chromium.org, Feb 8 2018

Just to update, latest asan canary version: 66.0.3343.1 has been live for 6 hours and has not reported any crashes so far, for '[Assert] `anonymous namespace'::V8DcheckCallbackHandler' and 'v8::base::TimeTicks::HighResolutionNow'. 

Comment 8 by gab@chromium.org, Feb 8 2018

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9ca75fb6352ae2e18aa6dd3f7d55b3330ce82574

commit 9ca75fb6352ae2e18aa6dd3f7d55b3330ce82574
Author: Myles Borins <mylesborins@google.com>
Date: Fri Apr 06 16:13:45 2018

[time] remove High-resolution PrintError

A DCHECK in TimeTicks::HighResolutionNow was replaced with
a warning to stop systems from crashing. This warning broke
parts of the Node.js test-suite on certain systems.

The warning has been replaced with a comment documenting
this situation and a TODO to ensure we don't lose track
of this code path.

Bug: v8:7617
Bug:  chromium:809016 
Change-Id: I5e3af8c31817291d264af861514f34e3e1af9af2
Reviewed-on: https://chromium-review.googlesource.com/997153
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Myles Borins <mborins@google.com>
Cr-Commit-Position: refs/heads/master@{#52458}
[modify] https://crrev.com/9ca75fb6352ae2e18aa6dd3f7d55b3330ce82574/src/base/platform/time.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 9 2018

Labels: merge-merged-6.6
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d27e94917f546ac91714603736ac3dae8bfcd16a

commit d27e94917f546ac91714603736ac3dae8bfcd16a
Author: Myles Borins <mylesborins@google.com>
Date: Mon Apr 09 20:21:47 2018

Merged: [time] remove High-resolution PrintError

Revision: 9ca75fb6352ae2e18aa6dd3f7d55b3330ce82574

BUG= chromium:809016 
BUG= v8:7636 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Change-Id: I298c636f96af39e324c4fef86d2e31f698e27fb0
Reviewed-on: https://chromium-review.googlesource.com/1003154
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Myles Borins <mborins@google.com>
Cr-Commit-Position: refs/branch-heads/6.6@{#39}
Cr-Branched-From: d500271571b92cb18dcd7b15885b51e8f437d640-refs/heads/6.6.346@{#1}
Cr-Branched-From: 265ef0b635f8761df7c89eb4e8ec9c1a6ebee184-refs/heads/master@{#51624}
[modify] https://crrev.com/d27e94917f546ac91714603736ac3dae8bfcd16a/src/base/platform/time.cc

Sign in to add a comment