New issue
Advanced search Search tips

Issue 809014 link

Starred by 1 user
Status: Verified
Owner:
fhorschig@chromium.org
Closed: Feb 2018
Cc:
maxwalker@chromium.org
fhorschig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 794108



Sign in to add a comment

Search disappears if opened twice without closing

Project Member Reported by fhorschig@chromium.org, Feb 5 2018 
Chrome Version: 66
OS: Android

What steps will reproduce the problem?
(1) Enable #password-search flag at chrome://flags
(2) Navigate to Settings > Save Passwords
(3) Click the search icon
(4) Open the overflow menu and click on "Search"
(5) Close the search

What is the expected result?
The action bar after (5) is like it was before (1).

What happens instead?
The search icon is gone. The search option isn't even available in the overflow menu.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb78c9a80e97a2e1862c30e9371c4345da97d4de

commit eb78c9a80e97a2e1862c30e9371c4345da97d4de
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Feb 12 12:40:45 2018

Fix the password search icon and view layout

The "ifRoom" property doesn't work properly with action views as the
main item will not collapse in that case and just move the option to
the settings menu.
Using "always" (like Site Settings does it) fixes that issue.
Removing the previously used "collapseActionView" prevents filling
the entire action bar which fixes layouting on large screens.

All other changes ensure no regressions although we now have to rely
on different Listener methods and UI interaction flows.


Bug:  809014 ,  807303 
Change-Id: I63a07b8b91077e33c50e4859889474d072cb7c94
Reviewed-on: https://chromium-review.googlesource.com/909217
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536065}
[modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml
[modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/eb78c9a80e97a2e1862c30e9371c4345da97d4de/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

Comment 2 by fhorschig@chromium.org, Feb 12 2018

Blocking: 794108
Status: Fixed (was: Assigned)
Fixed and tested.

Comment 3 by kgna...@chromium.org, Feb 13 2018

Status: Verified (was: Fixed)
Works as per expected behavior that is search icon is available although we click on close button. Issue verified on 66.0.3346.0
►

Sign in to add a comment