Port ProfileChooserView away from using ProfileOAuth2TokenService |
||||
Issue descriptionProfileChooserView is an O2TS observer to update UI on refresh tokens being made available / revoked. It revokes tokens with PO2TS. It gets the authenticated account info to populate UI with. It also checks whether signin is allowed. This is very similar to crbug.com/808986 and should probably be tackled together with that bug.
,
Dec 10
Updating the bug to reflect the current state of the world and be scoped to PO2TS; ProfileChooserView already no longer uses SigninManager and there's just a stale include there that should be removed. ProfileChooserView observes PO2TS and revokes refresh tokens. For the former, it will observe IdentityManager; for the latter, it should use AccountsMutator. We need to bring up the APIs for revoking fresh tokens in the latter (see blocking bug).
,
Dec 14
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93cae7faa893a055c6a832396666f58815e1256a commit 93cae7faa893a055c6a832396666f58815e1256a Author: Mario Sanchez Prada <mario@igalia.com> Date: Thu Jan 10 16:28:25 2019 Port ProfileChooserView away from using ProfileOAuth2TokenService Move to implementing identity::IdentityManager::Observer now and to using the AccountsMutator's API to remove accounts, instead of relying on the APIs from ProfileOAuth2TokenService. Bug: 808989 Change-Id: I649f1927eee670744c26255351d77cdbc0fd0a2d Reviewed-on: https://chromium-review.googlesource.com/c/1377854 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#621595} [modify] https://crrev.com/93cae7faa893a055c6a832396666f58815e1256a/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/93cae7faa893a055c6a832396666f58815e1256a/chrome/browser/ui/views/profiles/profile_chooser_view.h
,
Jan 10
|
||||
►
Sign in to add a comment |
||||
Comment 1 by blundell@chromium.org
, Feb 5 2018Components: Internals>Services>Identity
Status: Available (was: Untriaged)