New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808943 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to open actions menu list in 'Tabs from other devices' under chrome://history/

Reported by vineetha...@etouch.net, Feb 5 2018

Issue description

Chrome Version: 66.0.3340.0 (Official Build) Revision cf4b77e4ccc0da994c6322f71863b0d17bb5c99f-refs/heads/master@{#534315} (32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history/
(2) Click on 'Tabs from other devices' option from the LHS menu.
(3) Sign in to chrome with valid credentials and observe that a list of all devices is displayed.
(4) Try clicking on the 'actions' icon for any of the entry and observe.
  
Actual Result: Unable to open actions menu list on clicking 'actions' icon.
Expected Result: Actions menu list should open on clicking 'actions' icon.

This is regression issue broken in ‘M-66’ and providing the bisect using per-revision bisect,
Good build: 66.0.3336.0 (Revision: 533410)
Bad build: 66.0.3338.0 (Revision: 534242)

You are probably looking for a change made after 533916 (known good), but no later than 533917 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/c5d6215aa737d444849bdc614f0fcd96c8ce6edc..c69754281d9862212a7957ee367812dcb52bfb18

Suspect: https://chromium.googlesource.com/chromium/src/+/c69754281d9862212a7957ee367812dcb52bfb18

@dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

 
ActualVideo.mp4
1.5 MB View Download
ExpectedVideo.mp4
1.2 MB View Download
Labels: RegressedIn-66 FoundIn-66 Target-66
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
I'll take a look shortly. Probably missed some usages of cr-action-menu in my original CL.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4c91111d834681bd5b9603a94a8f8d6dd9f215

commit da4c91111d834681bd5b9603a94a8f8d6dd9f215
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 06 00:43:01 2018

History UI: Fix synced tabs cr-action-menu.

It was missed in r533917.

Bug:  808182 , 808943 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e6774385b6fe2484f7f92042e2442e4bf1e6267
Reviewed-on: https://chromium-review.googlesource.com/902771
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534559}
[modify] https://crrev.com/da4c91111d834681bd5b9603a94a8f8d6dd9f215/chrome/browser/resources/md_history/synced_device_manager.html

Status: Fixed (was: Started)
Labels: TE-Verified-M66 TE-Verified-66.0.3341.0
Update : 
Retested above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS using latest Canary #66.0.3341.0 and issue is fixed. Kindly review the attached screen-cast.
FixedVideo.mp4
1.3 MB View Download

Sign in to add a comment