New issue
Advanced search Search tips

Issue 808935 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android Language Settings launch and cleanup

Project Member Reported by goog...@chromium.org, Feb 5 2018

Issue description

We got the approval from leadership to launch the new feature "Android language settings" (crbug/783049, crbug/781915).

This bug will be used for tracking launch config changes on Chromium side and cleanup changes.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b1393cef92fc1b946e3ecbd862097526867fc50

commit 9b1393cef92fc1b946e3ecbd862097526867fc50
Author: Leo Zhang <googleo@chromium.org>
Date: Tue Feb 06 00:41:42 2018

Add LanguageSettingsAndroid in fieldtrial_testing_config.

To fix the warning from cl/184235490, we need to add the missing
Chromium field trial config.

Bug: 808935
Change-Id: I2624b09a27175a2d24f631ac77175dfc69c5ff1f
Reviewed-on: https://chromium-review.googlesource.com/901042
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534557}
[modify] https://crrev.com/9b1393cef92fc1b946e3ecbd862097526867fc50/testing/variations/fieldtrial_testing_config.json

Hey Leo, can this be marked as fixed?
I will start cleanup after 100% on stable. Will fix it before M67 (next release)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccdec6248826abc9205fb1d61818b62b179b74e

commit 5ccdec6248826abc9205fb1d61818b62b179b74e
Author: Leo Zhang <googleo@chromium.org>
Date: Fri Mar 16 04:58:20 2018

Set language settings enabled as default on TOT.

We have got the approval to launch this feature from M65.
See crbug/781915. In order to set the experiment configuration to 100%,
I need to enable it on TOT first. And there will be other CLs to clean
all the experiment code.

Bug: 808935
Change-Id: I86bf02ebe847b8841d7a0b2bddde4a3bfd7a537e
Reviewed-on: https://chromium-review.googlesource.com/964108
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543629}
[modify] https://crrev.com/5ccdec6248826abc9205fb1d61818b62b179b74e/chrome/browser/android/chrome_feature_list.cc

Sign in to add a comment