New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808928 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 794782
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

onended event gets not fired at the end of a mp3 audio stream containing id3v2 cover image media tag

Reported by albert.s...@gmail.com, Feb 5 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
1. Try playback any mp3 audio stream containing a id3v2 cover image media tag
2. 
3. 

What is the expected behavior?
At the end of the stream the onended event gets fired (https://www.w3schools.com/jsref/event_onended.asp)

What went wrong?
Playback is stopping before the end of the stream. No onended event is fired.

Did this work before? Yes 63.0.3239.132 (Official Build) (64-bit)

Does this work in other browsers? Yes

Chrome version: 64.0.3282.140  Channel: stable
OS Version: 10.0
Flash Version: 

This affects also Chrome on Android.
 
01. an_artist - a_title.mp3
495 KB Download
01. an_artist - a_title.mp3
495 KB Download

You may use this fiddle to test the downloaded sample file. But you can use any other mp3-file with cover art image for testing.
https://jsfiddle.net/mucas/hnapmbrL/

Comment 2 Deleted

Labels: Needs-Triage-M64
Labels: Needs-Bisect
Cc: sc00335...@techmahindra.com
Components: Internals>Media>FFmpeg
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision Triaged-ET RegressedIn-64 M-64 FoundIn-64 Target-64 OS-Linux OS-Mac Pri-1
Owner: dalecur...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 64.0.3282.140 and on latest canary 66.0.3340 using Mac 10.3.3, Ubuntu 14.04 and Windows 10.

Good Build: 64.0.3257.0
Bad Build: 64.0.3258.0

You are probably looking for a change made after 513689 (known good), but no later than 513690 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/7642e1c5fc5715dc1894eaf828ef85ae0a5d1fb7..9f57237995f7921b4dcd8855f1f6fe98874218d2

Reviewed-on: https://chromium-review.googlesource.com/738626

Suspecting same from changelog.

@dalecurtis: Please confirm the bug and help in re-assigning if it is not related to your change. Adding RB-Stable for M-64, Please change if not the case.

Thanks!
Probably another variant of  issue 794782 . Will take a look at the streams to see if they're valid. FFmpeg should be handling the id3 data correctly.
Mergedinto: 794782
Status: Duplicate (was: Assigned)
It's not the id3 tag, there's other junk in the file; you can fix this with http://mp3val.sourceforge.net/ :

$ mp3val -f 01.\ an_artist\ -\ a_title.mp3 
Analyzing file "01. an_artist - a_title.mp3"...
WARNING: "01. an_artist - a_title.mp3" (offset 0x358d): MPEG stream error, resynchronized successfully
WARNING: "01. an_artist - a_title.mp3" (offset 0x78a12): Garbage at the end of the file
WARNING: "01. an_artist - a_title.mp3": Wrong CRC in 1 frames
INFO: "01. an_artist - a_title.mp3": 1149 MPEG frames (MPEG 1 Layer III), +ID3v1+ID3v2, CBR, CRC
Rebuilding file "01. an_artist - a_title.mp3"...
FIXED: "01. an_artist - a_title.mp3": File was rebuilt
Done!

$ ffmpeg -i 01.\ an_artist\ -\ a_title.mp3 
Input #0, mp3, from '01. an_artist - a_title.mp3':
  Metadata:
    title           : a_title
    artist          : an_artist
    album           : an_album
    TLEN            : 30000
  Duration: 00:00:30.00, start: 0.000000, bitrate: 131 kb/s
    Stream #0:0: Audio: mp3, 44100 Hz, stereo, s16p, 128 kb/s
    Stream #0:1: Video: mjpeg, yuvj420p(pc, bt470bg/unknown/unknown), 133x124 [SAR 96:96 DAR 133:124], 90k tbr, 90k tbn, 90k tbc
    Metadata:
      comment         : Cover (front)

Sign in to add a comment