New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808907 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[desktop-pwas] Remove "Show in toolbar" extension context menu item

Project Member Reported by calamity@chromium.org, Feb 5 2018

Issue description

Extensions context menus in the DPWA menu have options like 'Show in toolbar' that shouldn't be visible at all, as well as other buttons like 'Manage extensions' which open in the current window, and break the DPWA experience. These should be audited and fixed.
 

Comment 1 by mgiuca@chromium.org, Mar 26 2018

Labels: M-67

Comment 2 by mgiuca@chromium.org, Mar 27 2018

Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Summary: [desktop-pwas] Remove "Show in toolbar" extension context menu item (was: [desktop-pwas] Polish extension context menu in DPWAs)
I've gone through the menu items.

- $EXTENSION_NAME -- opens Web Store in a browser tab [good]
- Options -- opens options page in a browser tab [good]
- Remove from Chrome -- crashes:  Issue 825554  [bad]
- Show in toolbar -- discussed below [questionable]
- Manage extensions -- opens manage page in a browser tab (must've been fixed since you reported) [good]
- Inspect popup -- popup opens in app window, then inspect window opens on top [good]

So all of this is good except Remove from Chrome and Show in toolbar.

Show in toolbar is tricky. It technically does the right thing, which is to bring that extension to the front and show it in the Chrome toolbar, but it doesn't make any visible difference on the app window. I would be happy to simply delete this item from the menu. However, it is a fairly minor problem.

So I'm renaming this issue to just reflect that, and keeping Pri-3.
Labels: -M-67 M-68
67 has branched, moving bugs over to 68.

Comment 4 by mgiuca@chromium.org, Jun 18 2018

Labels: -M-68 M-69
Bulk punting M68 PWA bugs to M69.
Status: Assigned (was: Available)

Sign in to add a comment