[desktop-pwas] Find and eliminate inconsistencies from popping DPWAs in and out of a tab |
|||
Issue descriptionThere exist some minor inconsistencies that arise from tabs popped into and out of a tabbed browser via Open in Chrome, or an omnibox action. Examples: - You can't drag URLs to a popped-in tab's body, and you can drag URLs to a popped-out tab's body - You can't press 'Add to shelf' on a popped-in tab, as after adding the app, the tab just closes A popped-in/out tab should behave exactly as if the tab had been opened originally in that context.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcac90e5257d772e0e27e9cc9e197a8108bae46b commit dcac90e5257d772e0e27e9cc9e197a8108bae46b Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Mar 20 05:51:31 2018 desktop-pwas: Set/unset app-specific prefs in TabInsertedAt/TabRemovedAt WebContents in app windows require certain prefs to be set. This happened in OpenApplication, but there are multiple ways for a WebContents to end up in an app window and also a WebContents that started in an app window could later move to regular tab. So, in some cases, a WebContents could end up in an app window without the necessary prefs or a WebContents could end up in a regular tab with app prefs set. Before, when an app window was opened through OpenApplication, OpenApplication would set app-specific prefs in the new app's WebContents. Now, HostedAppBrowserController sets the prefs when the WebContents is added to the tab strip. Before, nothing would unset the app-specific prefs when a WebContents was moved from an app window. Now, HostedAppBrowserController unsets the prefs when the WebContents is detached. Bug: 808901 Change-Id: I6b21e7e9090133755d8e45de7a216e4c5a5e1379 Reviewed-on: https://chromium-review.googlesource.com/958790 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#544293} [modify] https://crrev.com/dcac90e5257d772e0e27e9cc9e197a8108bae46b/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/dcac90e5257d772e0e27e9cc9e197a8108bae46b/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/dcac90e5257d772e0e27e9cc9e197a8108bae46b/chrome/browser/ui/extensions/hosted_app_browser_controller.h [modify] https://crrev.com/dcac90e5257d772e0e27e9cc9e197a8108bae46b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
,
Mar 26 2018
,
Mar 26 2018
The latest patch fixed the first example. The second example can no longer be reproduced. |
|||
►
Sign in to add a comment |
|||
Comment 1 by calamity@chromium.org
, Feb 5 2018