New issue
Advanced search Search tips

Issue 808837 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/css/css-pseudo/first-letter-002.html and first-letter-003.html give two pixel difference on Linux

Project Member Reported by cnardi@chromium.org, Feb 4 2018

Issue description

See for instance https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/28142/layout-test-results/results.html - two pixels on the edge of the box are painted an incorrect color.
 
Labels: Test-Layout
Status: Available (was: Untriaged)
I don't think we can fix this, but maybe it's possible.
Yeah, this is probably something that could be fixed easier with a change to the test; I'm not sure why two pixels are painted off to the side of the box anyway.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc16e5124301433c95edd8d3b9929164dac7524b

commit dc16e5124301433c95edd8d3b9929164dac7524b
Author: Chris Nardi <cnardi@chromium.org>
Date: Tue Feb 06 18:07:54 2018

Import wpt/css/css-pseudo

Import wpt/css/css-pseudo. 3 tests were added to NeverFixTests as
::marker has not been implemented. first-letter-001.html passes only on
Mac and first-letter-002/003.html only fail on Linux.

Bug: 808834,  808837 
No-Export: true
Change-Id: I3a248cb0d927de755313b05fb885b0348885886d
Reviewed-on: https://chromium-review.googlesource.com/900686
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534717}
[modify] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-001-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-001.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-002.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-003.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-004-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-004.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-and-other-pseudo-elements-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-color-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-color.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-font-properties-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-font-properties.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-inherit-values-ref.html
[add] https://crrev.com/dc16e5124301433c95edd8d3b9929164dac7524b/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/marker-inherit-values.html

Comment 4 by cnardi@chromium.org, Apr 21 2018

Looks like this was fixed by https://crrev.com/548309, I'll upload a CL to remove the expectations.

Comment 5 by cnardi@chromium.org, Apr 21 2018

Owner: cnardi@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77198f1e2b1fc809d71dfdc8fb75aadc3312b1c8

commit 77198f1e2b1fc809d71dfdc8fb75aadc3312b1c8
Author: Chris Nardi <cnardi@chromium.org>
Date: Mon Apr 23 14:47:12 2018

Remove failure expectation for first-letter-002/003.html on Linux

Both of these tests appear to be passing consistently after
https://crrev.com/548309; remove the failure expectation.

Bug:  808837 
Change-Id: I684ec2ea2571d4864497bb210eeba659c3b7d118
Reviewed-on: https://chromium-review.googlesource.com/1023339
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552693}
[modify] https://crrev.com/77198f1e2b1fc809d71dfdc8fb75aadc3312b1c8/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by cnardi@chromium.org, Apr 23 2018

Status: Fixed (was: Started)

Sign in to add a comment