New issue
Advanced search Search tips

Issue 808831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 554287



Sign in to add a comment

TabContentsIterator needs a redesign

Project Member Reported by a...@chromium.org, Feb 3 2018

Issue description

TabContentsIterator should be C++11ified.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f97ce593ed53edd553ba6f438896d1e3b218688

commit 2f97ce593ed53edd553ba6f438896d1e3b218688
Author: Avi Drissman <avi@chromium.org>
Date: Wed Feb 07 23:48:23 2018

Modernize the tab contents iterator.

BUG= 808831 

Change-Id: I474d9d919cd2e79444caea1e75cc4d039df1f1b8
Reviewed-on: https://chromium-review.googlesource.com/899799
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535193}
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/ash/media_client.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/browser_finder.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/hung_renderer/hung_renderer_core.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/tab_contents/tab_contents_iterator.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/tab_contents/tab_contents_iterator.h
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/ui/views/task_manager_view_browsertest.cc
[modify] https://crrev.com/2f97ce593ed53edd553ba6f438896d1e3b218688/chrome/browser/usb/web_usb_detector.cc

Comment 2 by a...@chromium.org, Feb 8 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment