New issue
Advanced search Search tips

Issue 808829 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Feb 2018
Cc:
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cant rebuild chromium Minor patch) without rebuild ninja

Reported by juanka85...@gmail.com, Feb 3 2018 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36

Steps to reproduce the problem:
1. Build chromium as is
2. Edit a file (enable/disable a random feature)
3. Rebuild
4. See it

What is the expected behavior?
A succesful rebuild (as i've never touched a gn rule)

What went wrong?
[1/1] Regenerating ninja files
FAILED: build.ninja 
gn --root=../.. -q --script-executable=/usr/bin/python2 gen .
/bin/sh: gn: no se encontró la orden
ninja: error: rebuilding 'build.ninja': subcommand failed

Crashed report ID: no

How much crashed? Just one tab

Is it a problem with a plugin? N/A 

Did this work before? Yes 66.0.3336.5

Chrome version: 64.0.3282.119  Channel: canary
OS Version: 66.0.3338.0
Flash Version:

Comment 1 by rbasuvula@chromium.org, Feb 5 2018

Cc: rbasuvula@chromium.org
Components: Build
Labels: TE-NeedsTriageHelp
This looks like build related crash issue unable to do form TE end, hence adding the respective label for it to triage further.

Thank You!

Comment 2 by rbasuvula@chromium.org, Feb 5 2018

Labels: Needs-Triage-M64

Comment 3 by thomasanderson@chromium.org, Feb 7 2018

Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00eba186828272462f318ee7ff4ed2106a6388a7

commit 00eba186828272462f318ee7ff4ed2106a6388a7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Feb 10 00:00:31 2018

Fix gn reference in build.ninja after bootstrapping

After bootstrapping gn, build.ninja has a reference that looks something like:
command = ../../../../../../../../../../tmp/tmp9Pn0sv/gn --root=../.. -q gen .

This reference will be broken when the OS removes the temporary directory.  This
CL regenerates the build files using the gn executable from the build directory.

This on its own will update the reference to plain "gn", however we need the
reference to be "./gn", because "gn" might not exist in the PATH, or would point
to an old one from depot_tools.

BUG= 808829 
R=dpranke

Change-Id: I1b156a6af081a35ded152946af13a117563b8c1a
Reviewed-on: https://chromium-review.googlesource.com/905793
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535892}
[modify] https://crrev.com/00eba186828272462f318ee7ff4ed2106a6388a7/tools/gn/bootstrap/bootstrap.py
[modify] https://crrev.com/00eba186828272462f318ee7ff4ed2106a6388a7/tools/gn/filesystem_utils.cc
[modify] https://crrev.com/00eba186828272462f318ee7ff4ed2106a6388a7/tools/gn/filesystem_utils_unittest.cc

Comment 5 by thomasanderson@chromium.org, Feb 10 2018

Status: Fixed (was: Started)
►

Sign in to add a comment