New issue
Advanced search Search tips

Issue 808767 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 811246
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Bad-cast to blink::PaintLayer from invalid vptr in blink::PaintLayerScrollableArea::GetLayoutBox

Project Member Reported by ClusterFuzz, Feb 3 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5495448572526592

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x3fc5cba14150
Crash State:
  Bad-cast to blink::PaintLayer from invalid vptr
  blink::PaintLayerScrollableArea::GetLayoutBox
  blink::PaintLayerScrollableArea::UpdateScrollOffset
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=479114:479272

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5495448572526592

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 3 2018

Labels: Test-Predator-Auto-Owner
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/06d238a9e9311f536cb7c930ee6b6c28987c60ed ([RootLayerScrolls] Clear clipping cache when scrollbars change.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 3 2018

Labels: M-64
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 3 2018

Labels: Pri-1
Labels: -Type-Bug-Security -Pri-1 Pri-2 Type-Bug
This bug only happens when running tests (in this case, the "--run-layout-flag" to chromium).  Changing bug "type" away from security, since it cannot affect users.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233ed9ec8e280080c5fa08c1ef4b3e7957861053

commit 233ed9ec8e280080c5fa08c1ef4b3e7957861053
Author: Stefan Zager <szager@chromium.org>
Date: Tue Feb 06 02:33:24 2018

Delay AXObject notifications until end of UpdateScrollOffset

Speculative fix for crasher: if the accessibility notification
callback modifies the DOM tree, it may cause unspecified behavior.

Note that the crash only happens when using WebFrameTestClient, so it
doesn't affect users.

BUG= 808767 
R=skobes@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I53183a9642b875d27468ddb10027b0efb6feb689
Reviewed-on: https://chromium-review.googlesource.com/902775
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534597}
[modify] https://crrev.com/233ed9ec8e280080c5fa08c1ef4b3e7957861053/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Components: Blink>Scroll
This speculative fix didn't work, as it is still reproducing. 

Comment 7 by szager@chromium.org, Feb 12 2018

Mergedinto: 811246
Status: Duplicate (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Feb 16 2018

ClusterFuzz has detected this issue as fixed in range 537047:537050.

Detailed report: https://clusterfuzz.com/testcase?key=5495448572526592

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x3fc5cba14150
Crash State:
  Bad-cast to blink::PaintLayer from invalid vptr
  blink::PaintLayerScrollableArea::GetLayoutBox
  blink::PaintLayerScrollableArea::UpdateScrollOffset
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=479114:479272
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=537047:537050

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5495448572526592

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, May 23 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment