QuickView/FileManagerBrowserTest.Test/2 is Flaky |
|||||||
Issue descriptionFindit has detected a flake at test QuickView/FileManagerBrowserTest.Test/2. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I7d5dec7a7b8ef2ccb4e3de3e69ed376e58545adb Regression range: https://crrev.com/852c20100944af3addc1fb42b1724209480e838c..2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVypAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJuY2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNDAzNi9icm93c2VyX3Rlc3RzL1VYVnBZMnRXYVdWM0wwWnBiR1ZOWVc1aFoyVnlRbkp2ZDNObGNsUmxjM1F1VkdWemRDOHkMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
Feb 5 2018
Yes, indeed https://crrev.com/c/856378 seems like a culprit. The CL says it fixes the flakiness but it seems not. testui, fukino: Do you agree with reverting the CL?
,
Feb 5 2018
yutak@: I agree to revert this as this is low impact. fukino@: However, this is very weird as L71 seems to be checking whether webview_ is null but #1 still says "Cannot read property 'contentWindow' of null". https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_safe_media.js?l=71&rcl=d9a71c341af98d201c3c2cafc12f47612444db76
,
Feb 5 2018
OK, so I'm trying to revert this now.
,
Feb 5 2018
This is reverted as of https://chromium.googlesource.com/chromium/src/+/d532b44ae1f17234429c8d653fd5cca2a253b0e6 Now I'm moving this off of sheriff queue, and leave this bug to you. (Feel free to close if you don't need this bug to track the flakiness.)
,
Feb 5 2018
,
Feb 6 2018
,
Feb 22 2018
,
Feb 28 2018
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32c3b9ad1650af9935f282384790ae57df4b7cba commit 32c3b9ad1650af9935f282384790ae57df4b7cba Author: Noel Gordon <noel@chromium.org> Date: Mon May 14 10:18:06 2018 Remove QuickView openQuickViewForFoldersAfterClose test QuickView/FileManagerBrowserTest/Test0,1,2 (3 tests). The tests do the following: Test/0 open QuickView Test/1 open then close QuickView Test/2 open then close then open QuickView again The first two tests have run-time that is already near bot time limits so Test/2 trying to open QuickView again will likely exceed bot limits regularly and FAIL even in RELEASE. Remove this test. Bug: 836254, 808745 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb91410cd095a305e1d9b189e5139c49c22cd39c Reviewed-on: https://chromium-review.googlesource.com/1055911 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558247} [modify] https://crrev.com/32c3b9ad1650af9935f282384790ae57df4b7cba/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/32c3b9ad1650af9935f282384790ae57df4b7cba/ui/file_manager/integration_tests/file_manager/quick_view.js
,
May 14 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yutak@chromium.org
, Feb 5 2018