milo: console doesn't respect limit |
|||||||
Issue description"Win7 Tests (dbg)(1)" is so slow, one build can span tens of commits. As of now, even with ?numbuilds=200, i can see only only 4 builds in https://ci.chromium.org/p/chromium/g/chromium.win/console?numbuilds=200 and in https://ci.chromium.org/p/chromium/g/migration-side-by-side/console?numbuilds=200 (why is it called numbuilds if the Y-axis is commits?) this affects task force's ability to compare CI builders on LUCI to Buildbot. The side-by-side console is their main tool for that. They probably have to resort to builder view without by-commit alignment.
,
Feb 3 2018
This situation should improve substantially with triggered builds ( Issue 794499 ). The general question of disparity in builder rate does remain however. Do we have a sense for how large the range is between builders? Personally, I have indeed been using the builder views to compare Win7 Tests (dbg)(1). It might be helpful if we could filter in/out builder pairs... not sure if it's worth the overhead though.
,
Feb 3 2018
Nodir says he'll look into it because ?limit=200 isn't obeyed, likely in processing of gitiles.Log (only 100 comits show up).
,
Feb 3 2018
,
Feb 3 2018
(usefulness for slow builders or not would be a new feature; buildbot is also "not useful" in the same way.)
,
Feb 3 2018
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/16245a7bfb80a739f09ef5e524d957baf79f402e commit 16245a7bfb80a739f09ef5e524d957baf79f402e Author: Nodir Turakulov <nodir@google.com> Date: Fri Feb 09 02:43:14 2018 [milo] add paging to git.Log Change git.Log()'s min parameter to "limit". Now it returns exactly the requested number of commits, as opposed to >=min. Add paging to git.Log to support limit>100 Bug: 808734 Change-Id: I74ee7434be7d45318bf9d0881c737762fadf371a Reviewed-on: https://chromium-review.googlesource.com/905636 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/16245a7bfb80a739f09ef5e524d957baf79f402e/milo/frontend/view_console.go [modify] https://crrev.com/16245a7bfb80a739f09ef5e524d957baf79f402e/milo/git/log.go [modify] https://crrev.com/16245a7bfb80a739f09ef5e524d957baf79f402e/milo/git/log_test.go
,
Feb 12 2018
,
Feb 28 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hinoka@chromium.org
, Feb 3 2018