New issue
Advanced search Search tips

Issue 808728 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix PLM reporting of savings from client LoFi

Project Member Reported by ryansturm@chromium.org, Feb 3 2018

Issue description

Client LoFi savings is not split into the body estimate and the headers
estimate, so it is not being tracked in PLM correclty (which only looks
at body).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07d0193b832a218fe58cf672d1d1cf5e58991651

commit 07d0193b832a218fe58cf672d1d1cf5e58991651
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Feb 12 21:21:07 2018

Fixing PLM reporting of savings from client LoFi

Client LoFi savings was not split into the body estimate and the headers
estimate, so it was not being tracked in PLM correctly (which only looks
at body). This addresses that by moving the respective parts of the
computation into the correct methods. This renames the method as well,
and sources uesd_drp from a better location.

Bug:  808728 
Change-Id: I7c45edc8b9d72dd86e5aae0906a57305381f48d7
Reviewed-on: https://chromium-review.googlesource.com/899848
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536194}
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
[rename] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
[rename] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.h
[rename] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/data_reduction_proxy_util_unittest.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/07d0193b832a218fe58cf672d1d1cf5e58991651/components/data_reduction_proxy/core/common/BUILD.gn

Status: Fixed (was: Started)
Cc: sclit...@chromium.org
 Issue 780537  has been merged into this issue.

Sign in to add a comment