New issue
Advanced search Search tips

Issue 808718 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add WebContentsVideoCaptureDevice browser test to confirm cross-site isolation cases.

Project Member Reported by m...@chromium.org, Feb 3 2018

Issue description

With cross-site isolation turned on, we want to confirm that tab capture correctly captures all content; from the main render frame and all child frames that may be rendering for different origins.
 
Components: Internals>Sandbox>SiteIsolation

Comment 2 by m...@chromium.org, Feb 7 2018

Components: Internals>Media>ScreenCapture

Comment 3 by m...@chromium.org, Feb 7 2018

Components: -Internals>Media>Capture
Yuri can we please list the test cases here in more detail, particularly cases wrt security, and protected media playback

Comment 5 by m...@chromium.org, Feb 22 2018

Status: Available (was: Untriaged)
1. I don't believe this is asking for security reasons.

2. Protected media playback is interesting: We *do* want to confirm media playback falls-back to the non-protected surface impl when tab capture is active (as discussed with other stakeholders). So, we should see about testing for that.

3. The original purpose is just to make sure Surface aggregation works and results in the full tab (and all nested Surfaces) being captured as one composited unit.

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13eae2005d7b585f1cf3b9911aa797c1dd4e3862

commit 13eae2005d7b585f1cf3b9911aa797c1dd4e3862
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Feb 28 12:57:13 2018

Add cross-site tab capture test, and fix an OnFrameDamaged() assumption.

Adds a browser test to confirm that tab capture grabs all content and
content updates when cross-site render process isolation is turned on.

The addition of this test revealed a pre-existing bug where the consumer
would not get a video frame for updated content. This happened whenever
OnFrameDamaged() was being called before OnBeginFrame() (which can
happen when Surfaces are changed).

Bug:  808718 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic965ece20d4c40eb65cdb78452148283935e5184
Reviewed-on: https://chromium-review.googlesource.com/936661
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539806}
[modify] https://crrev.com/13eae2005d7b585f1cf3b9911aa797c1dd4e3862/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/13eae2005d7b585f1cf3b9911aa797c1dd4e3862/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc

Comment 7 by m...@chromium.org, Feb 28 2018

Labels: -Pri-3 Merge-Request-66 M-66 Pri-1
Owner: m...@chromium.org
Status: Fixed (was: Available)
Since writing the test revealed a bug (that was fixed), requesting merge.
Project Member

Comment 8 by sheriffbot@chromium.org, Feb 28 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We don't branch M66 until 2018-03-01.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by m...@chromium.org, Feb 28 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66
Oh, M-66 hasn't branched yet. Silly me!

Sign in to add a comment