New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808707 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[wasm] Workers don't have access to WebAssembly.instantiateStreaming

Project Member Reported by bradnelson@chromium.org, Feb 3 2018

Issue description

Web Workers don't appear to have access to WebAssembly.instantiateStreaming or compileStreaming.

Glancing at the bindings setup, this is probably just an oversight.

 

Comment 1 by ahaas@chromium.org, Feb 5 2018

Cc: -ahaas@chromium.org bradnelson@chromium.org
Owner: ahaas@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7566f0f5a88820cc89bd1c7e911a13575b99810b

commit 7566f0f5a88820cc89bd1c7e911a13575b99810b
Author: Andreas Haas <ahaas@chromium.org>
Date: Fri Feb 09 14:42:53 2018

[v8] Allow WebAssembly.compileStreaming on workers

WebAssembly.compileStreaming should work both on the main thread as well
as on workers. However, we did not register the callback which is
required for WebAssembly.compileStreaming on the isolate of workers.
With this CL we move the registration of the callback to the
V8Initializer, where I think it belongs, and then register it both for
the isolate of the main thread as well as for the isolate of the
workers.

To make this possible I moved the WasmResponseExtensions implementation
from bindings/modules/... to bindings/core/... Please let me know if
there is a better way to do it, I'm not too much familiar with the
abstractions on the chrome side.

R=haraken@chromium.org

Bug:  chromium:808707 
Change-Id: I35fa55a8c83feebbc93f66fe85fc0580cb343068
Reviewed-on: https://chromium-review.googlesource.com/908848
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535707}
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/LayoutTests/http/tests/wasm_streaming/wasm_response_apis.html
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/LayoutTests/http/tests/wasm_streaming/wasm_response_apis.js
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/bindings.gni
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[rename] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/core/v8/V8WasmResponseExtensions.cpp
[rename] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/core/v8/V8WasmResponseExtensions.h
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
[modify] https://crrev.com/7566f0f5a88820cc89bd1c7e911a13575b99810b/third_party/WebKit/Source/bindings/modules/v8/v8.gni

Comment 3 by ahaas@chromium.org, Feb 12 2018

Cc: ahaas@chromium.org
 Issue v8:7386  has been merged into this issue.

Comment 4 by ahaas@chromium.org, Feb 22 2018

Status: Verified (was: Started)

Comment 5 by ahaas@chromium.org, Feb 22 2018

Verified by mths on Chrome 66.0.3352.0
Cc: mathias@chromium.org

Sign in to add a comment