New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808703 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 808700



Sign in to add a comment

[Findit] Setup pipelines for auto-revert test culprits

Project Member Reported by chanli@chromium.org, Feb 2 2018

Issue description

Setup pipelines for auto-revert test culprits
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6

commit 00b4a7d9ec71f52e1250e7b2417e8e071ff235f6
Author: Chan <chanli@chromium.org>
Date: Wed Feb 14 00:34:37 2018

[Findit] Move culprit_actions logic to culprit_action.py

Some logic in gerrit.py isn't related to gerrit or irc. Move it out.
- Move logic that decides if Findit should auto create/commit a revert or if Findit should send notification to code review to culprit_action.
- Move collecting metrics to culprit_action.
- Move logic that decides if Findit should send notification to irc to culprit_action.

There should not be any functional change after this cl, but logic was moved around.

Bug:  808703 
Change-Id: I51b731edd3c2b18e52c33e301518d6033a8d3a4f
Reviewed-on: https://chromium-review.googlesource.com/910080
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/common/monitoring.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/index.yaml
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/waterfall/send_notification_to_irc_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/monitoring.py
[add] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/compile_failure/compile_culprit_action.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/submit_revert_cl_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/test/monitoring_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/gerrit.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/irc.py
[add] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/compile_failure/test/compile_culprit_action_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/parameters.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/create_revert_cl_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/00b4a7d9ec71f52e1250e7b2417e8e071ff235f6/appengine/findit/services/test/irc_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f892686fe9cac3c63cac235adaaeb1d2a43858ad

commit f892686fe9cac3c63cac235adaaeb1d2a43858ad
Author: Chan <chanli@chromium.org>
Date: Thu Feb 15 01:03:06 2018

[Findit] Add pipelines to auto revert culprits for consistent test failures.

Add pipelines to create and commit reverts for culprits of reliable test failures.

Bug:  808703 
Change-Id: I397ad19c32d0a04a567de658c21f48dae3043828
Reviewed-on: https://chromium-review.googlesource.com/914719
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/services/test_failure/test_culprit_action.py
[modify] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[add] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/services/test_failure/test/test_culprit_action_test.py
[modify] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/f892686fe9cac3c63cac235adaaeb1d2a43858ad/appengine/findit/services/compile_failure/compile_culprit_action.py

Comment 4 by chanli@chromium.org, Feb 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment