New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 805730



Sign in to add a comment

[Findit] Refactor remaining pipelines to use BasePipeline

Project Member Reported by chanli@chromium.org, Feb 2 2018

Issue description

Remaining pipelines includes:
 - Start_compile_try_job_pipeline
 - Analyze_compile_failure_pipeline
 - Start_test_try_job_pipeline
 - Analyze_test_failure_pipeline

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/021634ef190439f938c6c8f3ffa13f2c285034dd

commit 021634ef190439f938c6c8f3ffa13f2c285034dd
Author: Chan <chanli@chromium.org>
Date: Tue Jul 31 01:10:29 2018

[Findit] Refactor StartCompileTryJobPipeline to inherit from new BasePipeline

Bug:  808699 
Change-Id: I868d71bdbbe0c1e12332ec57028800c5f248beec
Reviewed-on: https://chromium-review.googlesource.com/1148947
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/compile_failure/test/analyze_compile_failure_pipeline_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[rename] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/dto/start_waterfall_try_job_inputs.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/test_failure/test_try_job.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/services/try_job.py
[modify] https://crrev.com/021634ef190439f938c6c8f3ffa13f2c285034dd/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/549d9d95468bd98ad3ef6fbd241433e752fa819c

commit 549d9d95468bd98ad3ef6fbd241433e752fa819c
Author: Chan <chanli@chromium.org>
Date: Tue Jul 31 01:20:40 2018

[Findit] Refactor AnalyzeCompileFailurePipeline to inherit from new BasePipeline

Bug:  808699 
Change-Id: I4e7df7ee08981d33f326405d31f4c1cd2208b558
Reviewed-on: https://chromium-review.googlesource.com/1153218
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/pipelines/compile_failure/test/analyze_compile_failure_pipeline_test.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/waterfall/build_failure_analysis_pipelines.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/model/test/wf_analysis_test.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/model/wf_analysis.py
[modify] https://crrev.com/549d9d95468bd98ad3ef6fbd241433e752fa819c/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dce1c25fe0b86fd3d4a34b17adfc90e5279f9869

commit dce1c25fe0b86fd3d4a34b17adfc90e5279f9869
Author: Chan <chanli@chromium.org>
Date: Tue Jul 31 18:18:56 2018

[Findit] Refactor TriggerFlakeAnalysesPipeline

Move TriggerFlakeAnalysesPipeline from waterfall/flake/ to pipelines/ since it's a bridge pipeline between consistent failure analysis and flake analysis.
Also make the pipeline inherit from the new BasePipeline.

Bug:  808699 
Change-Id: Ic5e1230d4920aed8dc320b8f5b1b4c082cf1fa89
Reviewed-on: https://chromium-review.googlesource.com/1155380
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/dce1c25fe0b86fd3d4a34b17adfc90e5279f9869/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py
[modify] https://crrev.com/dce1c25fe0b86fd3d4a34b17adfc90e5279f9869/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[rename] https://crrev.com/dce1c25fe0b86fd3d4a34b17adfc90e5279f9869/appengine/findit/pipelines/trigger_flake_analyses_pipeline.py
[rename] https://crrev.com/dce1c25fe0b86fd3d4a34b17adfc90e5279f9869/appengine/findit/pipelines/test/trigger_flake_analyses_pipeline_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment