See the link to graphs below.
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=808665 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=3bfcada03261dcd43db058e7f2006272b5e591d674d38dd85ddfa165aa4d096c Bot(s) for this bug's original alert(s): android-nexus5 android-nexus5X android-nexus6 android-nexus7v2 android-one
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15b9ba0e840000
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/15b9ba0e840000 Revert to libpng version 1.6.22 by scroggo@google.com chromium @ d59d694cd460c08892a2ca1825104ae5260e70ad Rename traits and interface directories in //device by reillyg@chromium.org chromium @ fa93b142ca746c85c0714be0f2e1eee194f65697 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
Thanks for the report, this regression is known and is due to the revert of the libpng, as the latest version had an issue upstream (https://bugs.chromium.org/p/chromium/issues/detail?id=807324). The perf regression is because the code in ToT is missing a NEON optimization for handling PNGs palette (https://chromium.googlesource.com/chromium/src/+/c4811af6d72836d44a3630beecebb0ff55875ab1). We are planning to work along this week to re-land the optimization.
Assigning the bug and adding Richard.
I've successfully rebased the tip-of-tree optimization onto libpng 1.6.22, the patchset is undergoing internal review and will be uploaded shortly.
I've found the bug that caused the revert in issue 807324 , so I'll reland the optimization with the fix. Sorry for the trouble!
https://chromium-review.googlesource.com/c/chromium/src/+/902145 will reland the optimization.
Great news and thanks for fixing this one. Re-assigning the bug.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7b9a0fe6a75507cd007920762d008941edfc182 commit b7b9a0fe6a75507cd007920762d008941edfc182 Author: Leon Scroggins III <scroggo@google.com> Date: Tue Feb 06 19:12:06 2018 Reland update to libpng 1.6.34 with optimizations Bug: 807324 Bug: 808665 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but according to libpng-manual.txt, "hundreds of PNG files in the wild that have" this error, and we previously displayed them properly, so we should continue to do so. That bug is fixed with crrev.com/c/901985, which is safe to land prior to the (re-)upgrade. crrev.com/c/904262 is a regression test that will ensure that this does not re-break these images. Along with that fix, revert d59d694cd460c08892a2ca1825104ae5260e70ad, taking us back to 1.6.34 along with the arm optimizations that were reverted in that commit. Change-Id: I9ee925e25d94d1ba0d27fb9ba65abf9606f13828 Reviewed-on: https://chromium-review.googlesource.com/902145 Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#534744} [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/BUILD.gn [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/LICENSE [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/README [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/README.chromium [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/arm/filter_neon.S [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/arm/palette_neon_intrinsics.c [delete] https://crrev.com/4eacfee49b5de297908060fb9fb6153ff56f720f/third_party/libpng/contrib/intel/INSTALL [delete] https://crrev.com/4eacfee49b5de297908060fb9fb6153ff56f720f/third_party/libpng/contrib/intel/intel_sse.patch [rename] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/intel/filter_sse2_intrinsics.c [rename] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/intel/intel_init.c [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/patches/0000-plte.patch [add] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/patches/README [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/png.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/png.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngconf.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngerror.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngget.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pnginfo.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngmem.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngpread.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngprefix.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngpriv.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngread.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrio.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrtran.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngrutil.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngset.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngstruct.h [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngtest.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngtrans.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwio.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwrite.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwtran.c [modify] https://crrev.com/b7b9a0fe6a75507cd007920762d008941edfc182/third_party/libpng/pngwutil.c
Just confirming that the ARM perf bots are happy again: https://chromeperf.appspot.com/report?sid=c7436538fed52bbcf709bd9c14ad9161800f0cb9f75c606b297a33971e217cbb
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 2 2018