Issue metadata
Sign in to add a comment
|
352% regression in loading.mobile at 533109:533194 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 2 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c316de840000
,
Feb 4 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12c316de840000
,
Feb 5 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16fd6121840000
,
Feb 9 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/16fd6121840000
,
Feb 9 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a554d9840000
,
Feb 10 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14a554d9840000
,
Feb 10 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12a12675840000
,
Feb 10 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12a12675840000 viz: Tighten components/viz/service DEPS. by kylechar@chromium.org https://chromium.googlesource.com/chromium/src/+/78ed387b857f368934b7c95757ac82afd9fbf329 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 12 2018
I don't think changing DEPS include_rules made a performance difference. I hope not at least.
,
Feb 12 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12f34fed840000
,
Feb 12 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12f34fed840000
,
Feb 13 2018
,
Feb 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11dde03d840000
,
Feb 13 2018
This is a pretty big regression. Marking available, and starting a bisect with a wider range. Looks to me like the first point after the regression was noisily low.
,
Feb 15 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/11dde03d840000 [scheduler] Experiment to always treat input events as high-priority. by altimin@chromium.org https://chromium.googlesource.com/chromium/src/+/ef42564665d915f2d2294d0bfa3a9ab5632c9777 Remaining changes to build all code in src.git with -Wimplicit-fallthrough. by thakis@chromium.org https://chromium.googlesource.com/chromium/src/+/47d877575f265b60d1a412d6a01dc2d6eb8dc8d0 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 19 2018
My change just added explicit fallthroughs and is perf and behavior preserving. If the bisect is correct, it has to be altimin's change. (But given the earlier comments on the bug, I'm not sure I trust this bisect)
,
May 24 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 2 2018