New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808653 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression

Blocked on:
issue 846317



Sign in to add a comment

352% regression in loading.mobile at 533109:533194

Project Member Reported by npm@chromium.org, Feb 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=808653

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d3538faad47b835369783f528c202dae99a462cb20dfd23ad43f9e24428628d4


Bot(s) for this bug's original alert(s):

android-nexus6
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12c316de840000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16fd6121840000
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Feb 10 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14a554d9840000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Feb 10 2018

Cc: danakj@chromium.org kylec...@chromium.org
Owner: kylec...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a12675840000

viz: Tighten components/viz/service DEPS. by kylechar@chromium.org
https://chromium.googlesource.com/chromium/src/+/78ed387b857f368934b7c95757ac82afd9fbf329

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Labels: OS-Android
Owner: ----
Status: Untriaged (was: Assigned)
I don't think changing DEPS include_rules made a performance difference. I hope not at least.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Feb 12 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12f34fed840000
Status: WontFix (was: Untriaged)
Status: Available (was: WontFix)
This is a pretty big regression.

Marking available, and starting a bisect with a wider range. Looks to me like the first point after the regression was noisily low.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Feb 15 2018

Cc: rkaplow@chromium.org thakis@chromium.org zea@chromium.org altimin@chromium.org dtapu...@chromium.org
Owner: thakis@chromium.org
Status: Assigned (was: Available)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/11dde03d840000

[scheduler] Experiment to always treat input events as high-priority. by altimin@chromium.org
https://chromium.googlesource.com/chromium/src/+/ef42564665d915f2d2294d0bfa3a9ab5632c9777

Remaining changes to build all code in src.git with -Wimplicit-fallthrough. by thakis@chromium.org
https://chromium.googlesource.com/chromium/src/+/47d877575f265b60d1a412d6a01dc2d6eb8dc8d0

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: altimin@chromium.org
My change just added explicit fallthroughs and is perf and behavior preserving. If the bisect is correct, it has to be altimin's change. (But given the earlier comments on the bug, I'm not sure I trust this bisect)
Blockedon: 846317
Seems that something strange is happening with the metric.

Sign in to add a comment