New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 808598 link

Starred by 1 user
Status: Fixed
Owner:
sque@chromium.org
Closed: Feb 2018
Cc:
█ darekm@chromium.org
█ mnilsson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Less aggressive throttling of readLogSource calls.

Project Member Reported by sque@chromium.org, Feb 2 2018 
Currently Chrome throttles requests to readLogSource API at 1 request per second per log source per extension. This is slightly too aggressive as we might come across shorts "bursts" of calls on that API. Example: hooking in MIMO in one example as that results in multiple USB devices popping up at the same time.

From b/72857648
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9862bfdde21a4039a9e2502cb67aea9d775f7edc

commit 9862bfdde21a4039a9e2502cb67aea9d775f7edc
Author: Simon Que <sque@chromium.org>
Date: Tue Feb 06 17:55:44 2018

Increase access rate limit in readLogSource API

Allow the rate limiter to start with and accrue up to 10 access
allowances. This allows an extension to read multiple times from
the API in a short burst, while still being throttled if it goes
on for too long.

BUG= 808598 

Change-Id: I03746f2ee3ade64c87e2b2184467a8e66206a6b8
Reviewed-on: https://chromium-review.googlesource.com/900183
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534714}
[modify] https://crrev.com/9862bfdde21a4039a9e2502cb67aea9d775f7edc/extensions/browser/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/9862bfdde21a4039a9e2502cb67aea9d775f7edc/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/9862bfdde21a4039a9e2502cb67aea9d775f7edc/extensions/browser/api/feedback_private/log_source_access_manager.h

Comment 2 by sque@chromium.org, Feb 6 2018

Labels: M-65 Merge-Request-65
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 7 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f76f5c5a6f35544ddefe1051be518c99a2c1e4

commit 90f76f5c5a6f35544ddefe1051be518c99a2c1e4
Author: Simon Que <sque@chromium.org>
Date: Wed Feb 07 18:52:46 2018

Increase access rate limit in readLogSource API

Allow the rate limiter to start with and accrue up to 10 access
allowances. This allows an extension to read multiple times from
the API in a short burst, while still being throttled if it goes
on for too long.

BUG= 808598 

Change-Id: I03746f2ee3ade64c87e2b2184467a8e66206a6b8
Reviewed-on: https://chromium-review.googlesource.com/900183
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#534714}(cherry picked from commit 9862bfdde21a4039a9e2502cb67aea9d775f7edc)
Reviewed-on: https://chromium-review.googlesource.com/906691
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#365}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/90f76f5c5a6f35544ddefe1051be518c99a2c1e4/extensions/browser/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/90f76f5c5a6f35544ddefe1051be518c99a2c1e4/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/90f76f5c5a6f35544ddefe1051be518c99a2c1e4/extensions/browser/api/feedback_private/log_source_access_manager.h

Comment 5 by sque@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment