New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808592 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update sample extensions to use best practices.

Project Member Reported by crystallambert@chromium.org, Feb 2 2018

Issue description

Many sample extensions do not meet best practices or align with documentation. These need to be updated. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3452f187770965e8afe0d3b1082c9c0ff66ccdbb

commit 3452f187770965e8afe0d3b1082c9c0ff66ccdbb
Author: CrystalFaith <crystallambert@chromium.org>
Date: Tue Feb 06 02:18:30 2018

[Extension Docs]Update Sample Extension

Sample extension used "tabs" permission.
Updated it to "activeTab".

Bug: 808592
Change-Id: Id868dc8b5507a36a2efe5770f391718a53ae8478
Reviewed-on: https://chromium-review.googlesource.com/900129
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534589}
[modify] https://crrev.com/3452f187770965e8afe0d3b1082c9c0ff66ccdbb/chrome/common/extensions/docs/examples/api/browserAction/set_page_color/manifest.json
[modify] https://crrev.com/3452f187770965e8afe0d3b1082c9c0ff66ccdbb/chrome/common/extensions/docs/examples/api/browserAction/set_page_color/popup.js

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1091b4817360ab48f90dab53048a4033ef0be5

commit 8c1091b4817360ab48f90dab53048a4033ef0be5
Author: CrystalFaith <crystallambert@chromium.org>
Date: Wed Feb 07 23:02:03 2018

[Extension Docs]Update Sample Extension

Updated manifest to non persistent background.

Bug: 808592
Change-Id: Ib67576b8b5573eda32b2781c748f4e661a6ea305
Reviewed-on: https://chromium-review.googlesource.com/899509
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535177}
[modify] https://crrev.com/8c1091b4817360ab48f90dab53048a4033ef0be5/chrome/common/extensions/docs/examples/api/omnibox/simple-example/background.js
[modify] https://crrev.com/8c1091b4817360ab48f90dab53048a4033ef0be5/chrome/common/extensions/docs/examples/api/omnibox/simple-example/manifest.json

Sign in to add a comment