New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808584 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Proj-XR



Sign in to add a comment

Add to XR.PageSession how user got to page

Project Member Reported by tiborg@chromium.org, Feb 2 2018

Issue description

As discussed internally.
 

Comment 1 by sko...@chromium.org, Feb 27 2018

Labels: -Pri-1 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ea505356db122eb46c01377b6e6efe1270cbebf

commit 5ea505356db122eb46c01377b6e6efe1270cbebf
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Fri Mar 16 19:51:43 2018

Add code to record URL Omnibox entry in VR

For VR UKM Metrics recording.

Bug:  808584 
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I98418d91b0df01c265683362349cff6365d375c8
Reviewed-on: https://chromium-review.googlesource.com/959440
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543789}
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/metrics/session_metrics_helper.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/metrics/session_metrics_helper.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/5ea505356db122eb46c01377b6e6efe1270cbebf/tools/metrics/ukm/ukm.xml

Comment 5 by ericde@google.com, Mar 21 2018

Labels: -M-66 M-67
moving to M67
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4518558818681e014f819330f8cc9655a616769

commit e4518558818681e014f819330f8cc9655a616769
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Wed Mar 28 23:22:41 2018

Add Vr Start Action metric

Add a metric which tracks what prompted the user to enter VR in Chrome.

Bug:  808584 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I255bc45312309b315409188ccd276356c30894b7
Reviewed-on: https://chromium-review.googlesource.com/966879
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546650}
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/android/BUILD.gn
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/android/vr/vr_shell_delegate.h
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/vr/metrics/session_metrics_helper.cc
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/vr/metrics/session_metrics_helper.h
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/vr/service/vr_display_host.cc
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/chrome/browser/vr/service/vr_display_host.h
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/device/vr/BUILD.gn
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/device/vr/DEPS
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp
[modify] https://crrev.com/e4518558818681e014f819330f8cc9655a616769/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Started)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment