New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 808583 link

Starred by 1 user
Status: Fixed
Owner:
hungte@chromium.org
Closed: Feb 2018
Cc:
█ pbe...@chromium.org
jclinton@chromium.org
nsanders@chromium.org
sjg@chromium.org
bhthompson@google.com
shapiroc@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Test failure on chromeos-config-host

Project Member Reported by sjg@chromium.org, Feb 2 2018 
FEATURES=test sudo -E emerge chromeos-config-host

fails with:

>>> Test phase: chromeos-base/chromeos-config-host-9999
.....F.................................................................................
======================================================================
FAIL: testFirmware (cros_config_host.libcros_config_host_unittest.CrosConfigHostTest)
Test access to firmware information
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/chromeos-base/chromeos-config-host-9999/work/chromeos-config-host-9999/chromeos-config/cros_config_host/libcros_config_host_unittest.py", line 506, in testFirmware
    have_image=False, sig_id='whitetip2'))
AssertionError: OrderedDict([('blacktip', FirmwareInfo(model='blacktip', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='sig-id-in-customization-id')), ('blacktip-blacktip1', FirmwareInfo(model='blacktip-blacktip1', shared_model='caroline', key_id='BLACKTIP1', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='blacktip-blacktip1')), ('blacktip-blacktip2', FirmwareInfo(model='blacktip-blacktip2', shared_model='caroline', key_id='BLACKTIP2', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='blacktip-blacktip2')), ('caroline', FirmwareInfo(model='caroline', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='caroline')), ('pyro', FirmwareInfo(model='pyro', shared_model=None, key_id='', have_image=True, bios_build_target='pyro', ec_build_target='pyro', main_image_uri='bcs://Pyro.9042.87.1.tbz2', main_rw_image_uri='bcs://Pyro.9042.110.0.tbz2', ec_image_uri='bcs://Pyro_EC.9042.87.1.tbz2', pd_image_uri='bcs://Pyro_PD.9042.87.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='pyro')), ('reef', FirmwareInfo(model='reef', shared_model=None, key_id='', have_image=True, bios_build_target='pyro', ec_build_target='pyro', main_image_uri='bcs://Reef.9042.87.1.tbz2', main_rw_image_uri='bcs://Reef.9042.110.0.tbz2', ec_image_uri='bcs://Reef_EC.9042.87.1.tbz2', pd_image_uri='', extra=[], create_bios_rw_image=False, tools=[], sig_id='reef')), ('whitetip', FirmwareInfo(model='whitetip', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='sig-id-in-customization-id')), ('whitetip2', FirmwareInfo(model='whitetip2', shared_model='caroline', key_id='WHITETIP2', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='whitetip2'))]) != OrderedDict([('blacktip', FirmwareInfo(model='blacktip', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='sig-id-in-customization-id')), ('blacktip1', FirmwareInfo(model='blacktip1', shared_model='caroline', key_id='BLACKTIP1', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='blacktip1')), ('blacktip2', FirmwareInfo(model='blacktip2', shared_model='caroline', key_id='BLACKTIP2', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='blacktip2')), ('caroline', FirmwareInfo(model='caroline', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='caroline')), ('pyro', FirmwareInfo(model='pyro', shared_model=None, key_id='', have_image=True, bios_build_target='pyro', ec_build_target='pyro', main_image_uri='bcs://Pyro.9042.87.1.tbz2', main_rw_image_uri='bcs://Pyro.9042.110.0.tbz2', ec_image_uri='bcs://Pyro_EC.9042.87.1.tbz2', pd_image_uri='bcs://Pyro_PD.9042.87.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='pyro')), ('reef', FirmwareInfo(model='reef', shared_model=None, key_id='', have_image=True, bios_build_target='pyro', ec_build_target='pyro', main_image_uri='bcs://Reef.9042.87.1.tbz2', main_rw_image_uri='bcs://Reef.9042.110.0.tbz2', ec_image_uri='bcs://Reef_EC.9042.87.1.tbz2', pd_image_uri='', extra=[], create_bios_rw_image=False, tools=[], sig_id='reef')), ('whitetip', FirmwareInfo(model='whitetip', shared_model='caroline', key_id='', have_image=True, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='sig-id-in-customization-id')), ('whitetip2', FirmwareInfo(model='whitetip2', shared_model='caroline', key_id='WHITETIP2', have_image=False, bios_build_target='caroline', ec_build_target='caroline', main_image_uri='bcs://Caroline.2017.21.1.tbz2', main_rw_image_uri='bcs://Caroline.2017.41.0.tbz2', ec_image_uri='bcs://Caroline_EC.2017.21.1.tbz2', pd_image_uri='bcs://Caroline_PD.2017.21.1.tbz2', extra=[], create_bios_rw_image=False, tools=[], sig_id='whitetip2'))])

Comment 1 by sjg@chromium.org, Feb 2 2018

Cc: sjg@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3d75da107fff722e0c2aa3f8f8bc52f0761a4a3a

commit 3d75da107fff722e0c2aa3f8f8bc52f0761a4a3a
Author: Simon Glass <sjg@chromium.org>
Date: Fri Feb 02 23:25:30 2018

chromeos-config: Disable a failing test

This test was broken by a recent CL. Disable it for now to allow time to
fix it.

BUG= chromium:808583 
TEST=FEATURES=test sudo -E emerge chromeos-config-host

Change-Id: I155693358421600a55a22e70a9751a845071d8bb
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/900290
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/3d75da107fff722e0c2aa3f8f8bc52f0761a4a3a/chromeos-config/cros_config_host/libcros_config_host_unittest.py
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d06be184b341c4de7210beff21b1fbcbc6356468

commit d06be184b341c4de7210beff21b1fbcbc6356468
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Feb 07 23:04:21 2018

chromeos-config: Fix broken unittest for whitelabel.

The whitelabel tag format has been changed and the models populated in
chromeos-config should prefix reference model name.

BUG= chromium:808583 
TEST=FEATURES=test sudo -E emerge chromeos-config-host

Change-Id: I9bb71c8d09f8cbb9919ddefcd7e7891cc71f3a13
Reviewed-on: https://chromium-review.googlesource.com/905242
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/d06be184b341c4de7210beff21b1fbcbc6356468/chromeos-config/cros_config_host/libcros_config_host_unittest.py

Comment 4 by pbe...@chromium.org, Feb 8 2018

Labels: M-65 Merge-Request-65

Comment 5 by pbe...@chromium.org, Feb 8 2018

Cc: pbe...@chromium.org

Comment 6 by bhthompson@google.com, Feb 8 2018

Labels: -Merge-Request-65 Merge-Approved-65
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 12 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7c81048c7fcc85467838fbdd896eb5c60b04cde0

commit 7c81048c7fcc85467838fbdd896eb5c60b04cde0
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Feb 15 02:10:04 2018

chromeos-config: Fix broken unittest for whitelabel.

The whitelabel tag format has been changed and the models populated in
chromeos-config should prefix reference model name.

BUG= chromium:808583 
TEST=sudo FEATURES=test emerge chromeos-config-host

Change-Id: I9bb71c8d09f8cbb9919ddefcd7e7891cc71f3a13
Reviewed-on: https://chromium-review.googlesource.com/905242
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>
(cherry picked from commit d06be184b341c4de7210beff21b1fbcbc6356468)
Reviewed-on: https://chromium-review.googlesource.com/907951
Tested-by: Patrick Berny <pberny@chromium.org>
Commit-Queue: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/7c81048c7fcc85467838fbdd896eb5c60b04cde0/chromeos-config/cros_config_host/libcros_config_host_unittest.py

Comment 9 by pbe...@chromium.org, Feb 15 2018

Labels: -Merge-Approved-65
Status: Fixed (was: Untriaged)
►

Sign in to add a comment