New issue
Advanced search Search tips

Issue 808559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-base/minijail unittest failing

Project Member Reported by rahulchaudhry@chromium.org, Feb 2 2018

Issue description

Examples:
lakitu: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/1243
link: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/1244

The log contains:
make[1]: *** [common.mk:526: TEST(CXX_BINARY(minijail0_cli_unittest))] Error 1

Only observed on the llvm-next rotating builders so far, so suspect this has something to do with new version of llvm.

 
This does not seem related to llvm-next.
$ FEATURES=test emerge-lakitu chromeos-base/minijail
passed locally in a chroot with the new llvm compiler installed.

Was it a full build with llvm-next? Maybe the root cause is one of the minijail dependencies.

Can you try:
$ emerge-lakitu -e chromeos-base/minijail -j32 // Rebuild all dependent packages
$ FEATURES=test emerge-lakitu chromeos-base/minijail
It was not full build. I'll try again with full build.

However, lakitu unittests have passed before with llvm-next: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/1194
So if this is specific to llvm-next, it was probably triggered by some other change in minijail or its dependencies after Jan 27.

Yes, there is a chance that some dependent package is misbehaving. IIRC, in a recent llvm-next roll, one of the UnitTest fails was in Imageloader that was actually caused by dev-libs/nss miscompilation.

If llvm-next full repros the problem, then package bisection should help.
Components: Tools>ChromeOS-Toolchain
Owner: vapier@chromium.org
fix is here: https://android-review.googlesource.com/608866

Comment 7 by lloz...@google.com, Feb 6 2018

that sounds like the bug!

THanks Mike!
Thanks Mike.
I applied the patch locally and confirmed that it fixes the issue.

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/35114d479e6f0a88a7f22df8c9528f7dc511ab83

commit 35114d479e6f0a88a7f22df8c9528f7dc511ab83
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Feb 08 09:24:08 2018

minijail: pull in unittest fix

9741372f23e7 minijail0_cli_unittest: fix random crashes/failures

BUG= chromium:808559 
TEST=precq passes

Change-Id: I9f56ff8b8e624bbe6635edfc1274a78d16e97240
Reviewed-on: https://chromium-review.googlesource.com/907073
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/35114d479e6f0a88a7f22df8c9528f7dc511ab83/chromeos-base/minijail/minijail-1-r6.ebuild

Status: Fixed (was: Untriaged)
Components: OS>Systems>Minijail

Sign in to add a comment