New issue
Advanced search Search tips

Issue 808542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 738611



Sign in to add a comment

[Polymer2]: Migrate paper-icon-button-light to 2.1.0

Project Member Reported by dpa...@chromium.org, Feb 2 2018

Issue description

There are some breaking changes, which means all clients of paper-icon-button-light need to be updated (about 80 occurrences).

Before
<button is="paper-icon-button-light" class="subpage-arrow></button>

After
<paper-icon-button-light>
  <button class="subpage-arrow"></button>
</paper-icon-button-light>

There need to be updates to the styling rules as well, see [1]

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_icons_css.html?q=paper-icon-button-light+file:%5Esrc/ui/webui/resources/cr_elements/+package:%5Echromium$&dr=C&l=8
 
Blocking: 738611
Owner: hcarmona@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3

commit b6477fef9acbe00a3e8b58b6963b518b57575ed3
Author: Hector Carmona <hcarmona@chromium.org>
Date: Sat Mar 10 06:28:58 2018

WebUI: Update paper-icon-button from 1.1.6 to 2.1.0.

As part of the update, syntax for paper-icon-button-light changed, so
this CL will also update our usage of it.

R=dpapad@chromium.org

Bug:  808542 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9ac87a515e2d07084f85ab07b66b7f2e32f3d544
Reviewed-on: https://chromium-review.googlesource.com/907856
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542362}
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_bookmarks/shared_style.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/android_apps_page/android_settings_element.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/settings_icons_css.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings/zoom_levels.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/extensions/extension_kiosk_mode_test.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/system_page_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/chrome/test/data/webui/settings/usb_devices_tests.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light-extracted.js
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_icons_css.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html

Comment 4 by dpa...@chromium.org, Mar 20 2018

Is this fixed now?
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e538990678a45adaf895b39f850d22283c308992

commit e538990678a45adaf895b39f850d22283c308992
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Mar 22 19:05:19 2018

Fix a paper-icon-button-light that wasn't migrated

Bug:  808542 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc4a489a8854dd0af7b282f7f89304c6dd17456d
Reviewed-on: https://chromium-review.googlesource.com/973549
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545181}
[modify] https://crrev.com/e538990678a45adaf895b39f850d22283c308992/chrome/browser/resources/settings/reset_page/reset_page.html

Sign in to add a comment