Have LinearLayout respect an element's alignment preference |
|||||
Issue descriptionWhen LinearLayout positions elements, it centers them on the off-axis. Instead, the layout could accept an alignment property to align them to an edge instead. This would make particular layouts much easier to implement, and seems trivially cheap to compute.
,
Mar 15 2018
Ian needed this a few hours before I did. Passing bug over.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a7a379f90c8ddb3e618c2017bcda0c88c5edc4a commit 6a7a379f90c8ddb3e618c2017bcda0c88c5edc4a Author: Ian Vollick <vollick@chromium.org> Date: Thu Mar 15 21:46:01 2018 [vr] Handle alignment in linear layout This CL follows the approach described on crbug.com/808527 for respecting element alignment in the linear layout. Bug: 808527 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia11640da59ebcaf14ddd5d82df182ed7cacfd027 Reviewed-on: https://chromium-review.googlesource.com/964787 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543507} [modify] https://crrev.com/6a7a379f90c8ddb3e618c2017bcda0c88c5edc4a/chrome/browser/vr/elements/linear_layout.cc [modify] https://crrev.com/6a7a379f90c8ddb3e618c2017bcda0c88c5edc4a/chrome/browser/vr/elements/linear_layout_unittest.cc [modify] https://crrev.com/6a7a379f90c8ddb3e618c2017bcda0c88c5edc4a/chrome/browser/vr/ui_scene_creator.cc
,
Mar 15 2018
,
Mar 16 2018
,
Mar 16 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cjgrant@chromium.org
, Feb 13 2018