mosys: Quieten down the unified build identify search |
|||||||||||
Issue descriptionAt present mosys is quite noisy on coral: $ mosys platform model cros_config_setup_sku: Could not locate name 'Coral' in 'Fizz' cros_config_read_sku_info: Failed to read master configuration cros_config_setup_sku: Could not locate name 'Coral' in 'Kahlee,Grunt' cros_config_read_sku_info: Failed to read master configuration robo $ We should adjust the log level so that these (perfectly normal) messages do not appear.
,
Feb 2 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/e0229d0a61599c0fa7109b289078a6a84c7efd97 commit e0229d0a61599c0fa7109b289078a6a84c7efd97 Author: Simon Glass <sjg@chromium.org> Date: Sat Feb 03 16:47:17 2018 mosys: Quieten down the search for platform information At present mosys prints messages when scanning past platform tables that it decides not to use (since they are intended for another platform). This is confusing since it looks like something is wrong. Change these messages to debug so they don't appear except in verbose mode. BUG= chromium:808496 BRANCH=none TEST=manually test on robo: $ mosys platform model robo Change-Id: I4024219ba9fb0b8dfa055e645c37b8747b409d0d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/899780 Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/e0229d0a61599c0fa7109b289078a6a84c7efd97/include/lib/cros_config.h [modify] https://crrev.com/e0229d0a61599c0fa7109b289078a6a84c7efd97/lib/cros_config/cros_config.c
,
Feb 5 2018
,
Feb 5 2018
Please add affected OSs.
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/7976d79fb1f123d3c5b70722dbe1408b698e20d2 commit 7976d79fb1f123d3c5b70722dbe1408b698e20d2 Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 06 06:24:45 2018 mosys: Quieten down the search for platform information At present mosys prints messages when scanning past platform tables that it decides not to use (since they are intended for another platform). This is confusing since it looks like something is wrong. Change these messages to debug so they don't appear except in verbose mode. BUG= chromium:808496 BRANCH=none TEST=manually test on robo: $ mosys platform model robo Change-Id: I4024219ba9fb0b8dfa055e645c37b8747b409d0d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/899780 Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit e0229d0a61599c0fa7109b289078a6a84c7efd97) Reviewed-on: https://chromium-review.googlesource.com/903257 Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/7976d79fb1f123d3c5b70722dbe1408b698e20d2/include/lib/cros_config.h [modify] https://crrev.com/7976d79fb1f123d3c5b70722dbe1408b698e20d2/lib/cros_config/cros_config.c
,
Feb 6 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/02ec06c3fb7bcf8d81b80d2ce67fb84b25a414ff commit 02ec06c3fb7bcf8d81b80d2ce67fb84b25a414ff Author: Simon Glass <sjg@chromium.org> Date: Thu Feb 08 00:09:56 2018 mosys: Quieten down the search for platform information At present mosys prints messages when scanning past platform tables that it decides not to use (since they are intended for another platform). This is confusing since it looks like something is wrong. Change these messages to debug so they don't appear except in verbose mode. BUG= chromium:808496 BRANCH=none TEST=manually test on robo: $ mosys platform model robo Change-Id: I4024219ba9fb0b8dfa055e645c37b8747b409d0d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/899780 Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit e0229d0a61599c0fa7109b289078a6a84c7efd97) Reviewed-on: https://chromium-review.googlesource.com/902343 Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/02ec06c3fb7bcf8d81b80d2ce67fb84b25a414ff/include/lib/cros_config.h [modify] https://crrev.com/02ec06c3fb7bcf8d81b80d2ce67fb84b25a414ff/lib/cros_config/cros_config.c
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 14 2018
,
Feb 14 2018
,
Feb 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 22 2018
Does this need to be merged?
,
Mar 22 2018
Sorry Simon, it's been merged already and I forgot to close it again.
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/fab288c15c3df89f61e9f3fb4b19699b56c3cdc7 commit fab288c15c3df89f61e9f3fb4b19699b56c3cdc7 Author: Simon Glass <sjg@chromium.org> Date: Tue Mar 27 01:18:47 2018 mosys: Quieten down the search for platform information At present mosys prints messages when scanning past platform tables that it decides not to use (since they are intended for another platform). This is confusing since it looks like something is wrong. Change these messages to debug so they don't appear except in verbose mode. BUG= chromium:808496 BRANCH=none TEST=manually test on robo: $ mosys platform model robo Change-Id: I4024219ba9fb0b8dfa055e645c37b8747b409d0d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/899780 Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit e0229d0a61599c0fa7109b289078a6a84c7efd97) Reviewed-on: https://chromium-review.googlesource.com/981256 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/fab288c15c3df89f61e9f3fb4b19699b56c3cdc7/include/lib/cros_config.h [modify] https://crrev.com/fab288c15c3df89f61e9f3fb4b19699b56c3cdc7/lib/cros_config/cros_config.c |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sjg@chromium.org
, Feb 2 2018Status: Started (was: Untriaged)