remove au-generator.zip |
||||
Issue descriptionCurrently update_payload is being used as source and package in a few places including: - autoupdater.py: For copying update_payload to the device - as a dependency to devserver - canary paygenbuild and paygentests - cros payload: shows the specification of payloads So instead of depending on update_payload scripts in chromite, we can just add a new executable (in this case update_engine/scripts/paycheck.py) in /usr/bin for the sdk. This will require to add update_payload ebuild as a dependency to the sdk, and it will be installed in python/site-packages. Then in paygen_payload_lib.py instead of directly using the update_payload scripts, we can call the paycheck.py binary with proper arguments and possibly parse the output for success/failure checks. There are only three functionalities in this script: - apply a payload - check the integrity of the payload - get the manifest size The first two already exist in paycheck.py, the last one can easily be added. We can later do the same for cros_payload.py, by moving most of the functionality of cros_payload.py into paycheck.py. Once we do this, we can call the paycheck.py binary inside the chroot and it will solve our dependency issues. After this we can remove the au-generator.zip and all things associated with it and start generating payloads using the sdk itself. The sdk, already has a dependency to delta_generator and everything will be fine.
,
Feb 2 2018
@dgarrett: Do you think this is a reasonable plan?
,
Feb 2 2018
,
Feb 2 2018
Just to ask.... Would it make sense to extend "cros payloads" to be a replacement for paycheck/update_payload? That implies it depends on no external libraries, though it would, of course, depend on the delta generator binaries. Pro: Nearly every environment has access to chromite. ?? Con: Update engine logic ends up in chromite. ??
,
Feb 2 2018
The answer would be no, because update_payload is being used in AOSP and we want to keep them in sync.
,
Feb 2 2018
That makes sense. So... I think I like your plan!
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/272e2ed02c1d6dcd4e2a613a85001bbbf9f33b83 commit 272e2ed02c1d6dcd4e2a613a85001bbbf9f33b83 Author: Amin Hassani <ahassani@google.com> Date: Wed Feb 14 05:17:20 2018 cros_generate_update_payload: output payload metadata size We need to get the update payload metadata size somehow for paygen tests. This is the best way to do it. This patch adds out_metadata_size_file flag to cros_generate_update_payload. BUG= chromium:808495 TEST=unittest pass; payload tryjob Change-Id: I65c48565afbdfaff619d6ac08bd8d36a8fb59315 Reviewed-on: https://chromium-review.googlesource.com/912102 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/272e2ed02c1d6dcd4e2a613a85001bbbf9f33b83/host/cros_generate_update_payload
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/cfbe1e242e3ee483d87774328904594a6a96d5fe commit cfbe1e242e3ee483d87774328904594a6a96d5fe Author: Amin Hassani <ahassani@google.com> Date: Thu Feb 15 10:33:04 2018 cros_generate_update_payload: fix metadata_size_file In a previous CL:912102, the metadata size file was not passed to the correct command. This CL fixes it. BUG= chromium:808495 TEST='cros_generate_update_payload --out_metadata_size_file ./file' write into ./file the size of the metadata during payload generation. Change-Id: I0941deebbb6457daa39ca2adb742482fd06f3715 Reviewed-on: https://chromium-review.googlesource.com/919823 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/cfbe1e242e3ee483d87774328904594a6a96d5fe/host/cros_generate_update_payload
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/66941258da78af52ea9c254b38b0cdfbb21f724b commit 66941258da78af52ea9c254b38b0cdfbb21f724b Author: Amin Hassani <ahassani@google.com> Date: Sat Feb 17 05:41:21 2018 target-chromium-os-sdk: Add update_payload We need to install check_udpate_payload in the and sdk in order to run in the chroot. This patch replaces dev-python/backports-lzma with chromeos-base/update_payload because it is already dependent on dev-python/backports-lzma. BUG= chromium:808495 TEST=sdk contains the update_payload scripts Change-Id: Ic56b999d9f6585502a921acd85421702b0546d3c Reviewed-on: https://chromium-review.googlesource.com/899766 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/66941258da78af52ea9c254b38b0cdfbb21f724b/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r98.ebuild [modify] https://crrev.com/66941258da78af52ea9c254b38b0cdfbb21f724b/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f23d763a01385d51419e30e281b63dc85fe0f628 commit f23d763a01385d51419e30e281b63dc85fe0f628 Author: Amin Hassani <ahassani@google.com> Date: Sat Feb 17 05:41:19 2018 update_payload: Install paycheck.py script Install paycheck.py script in the /usr/bin as check_update_payload. This only happens for sdk targets. This is needed in order to run paygen scripts inside the chroot. BUG= chromium:808495 TEST=emerge update_payload Change-Id: Ic152d994efef8e3bad301fb76644475b098e65b5 Reviewed-on: https://chromium-review.googlesource.com/899768 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f23d763a01385d51419e30e281b63dc85fe0f628/chromeos-base/update_payload/update_payload-9999.ebuild
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/e20eb915eb1d9777bbcdcffb324ce92014cafa79 commit e20eb915eb1d9777bbcdcffb324ce92014cafa79 Author: Amin Hassani <ahassani@google.com> Date: Tue Mar 06 02:34:39 2018 update_payload: Allow paycheck.py to compare apply results. Currently paycheck.py only applies the payloads. The responsibility of checking if the final root and kernel partitions are what we wanted is out of paycheck.py. Currently when paycheck.py runs and applies a payload files passed by --dst_kern and --dst_root are populated with the newly generated partitions by applier.py. This patch adds two new flags --out_dst_kern and --out_dst_root so instead paychek.py outputs the new partitions into paths passed by these flags and --dst_kern and --dst_root is reserved for passing the actual original partitions that newly generated partitions need to be compared to. This allows paycheck.py to check the newly generated partitions against the given ones and make sure they are equal. BUG= chromium:808495 TEST=test_paycheck.sh old.full delta.bin new.full Change-Id: I57a476de1477e3cba7557d0564b49ec03253c047 Reviewed-on: https://chromium-review.googlesource.com/929652 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org> [modify] https://crrev.com/e20eb915eb1d9777bbcdcffb324ce92014cafa79/scripts/test_paycheck.sh [modify] https://crrev.com/e20eb915eb1d9777bbcdcffb324ce92014cafa79/scripts/paycheck.py
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2b164e5496dc37a50f8cec8d237040902e3b544e commit 2b164e5496dc37a50f8cec8d237040902e3b544e Author: Amin Hassani <ahassani@google.com> Date: Wed Mar 07 01:22:27 2018 paygen: Add InitSDK stage We need to run update_payload scripts inside chroot. But payload tryjobs do not build any chroot. This patch adds InitSDK stage fot payload tryjobs. BUG= chromium:808495 TEST=pre-cq TEST=ran operations through chroot Change-Id: I8cf46023df3ad98ee4728513b2f13436bd412001 Reviewed-on: https://chromium-review.googlesource.com/898026 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/2b164e5496dc37a50f8cec8d237040902e3b544e/cbuildbot/builders/release_builders.py
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/434dec06ac1a073121631a808620127c133eae30 commit 434dec06ac1a073121631a808620127c133eae30 Author: Amin Hassani <ahassani@google.com> Date: Wed Mar 07 01:22:28 2018 paygen: Run inside chroot Previously chromite was dependent on update_payload script for verifying update payloads. Also it was using files in au-generator.zip for payload generation and checking. However, this is not needed anymore because we always generate payloads using the latest code. Now we can just use the tools in the SDK itself for generating and verifying update. This CL starts generating and verify payloads inside the chroot. However it does not remove au-generator.zip yet. BUG= chromium:808495 TEST=unittest pass; payload tryjob Change-Id: I29c9f008fea174dcfd0426299b7c5ff95c32164e Reviewed-on: https://chromium-review.googlesource.com/899845 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/434dec06ac1a073121631a808620127c133eae30/lib/paygen/paygen_payload_lib_unittest.py [modify] https://crrev.com/434dec06ac1a073121631a808620127c133eae30/lib/paygen/utils.py [modify] https://crrev.com/434dec06ac1a073121631a808620127c133eae30/lib/paygen/paygen_payload_lib.py
,
Mar 7 2018
Paygens are running in chroot, yayyyy!!!
,
Mar 16 2018
@dgarrett: I suggest we wait a milestone to see these are working fine with release branches too before removing anything related to au-generator.zip. WDYT?
,
Mar 16 2018
Sounds like a very reasonable plan to me!
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/41a3c7960eb329b2292933f45a03623930b6bab5 commit 41a3c7960eb329b2292933f45a03623930b6bab5 Author: Amin Hassani <ahassani@google.com> Date: Tue Apr 03 19:50:44 2018 paygen: Log all chroot operations in the log file We were not storing payload hash generation and signing logs anywhere. This patch removes the individual log for verify and appends all the logs to the original delta_log. Also renames delta_log to just log because now it consist of more log types. BUG= chromium:808495 TEST=unittest TEST=payload tryjobs Change-Id: Idbd0f3f7559d6a113bfba357edd4a27b8b41c8ce Reviewed-on: https://chromium-review.googlesource.com/956265 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/41a3c7960eb329b2292933f45a03623930b6bab5/lib/paygen/paygen_payload_lib_unittest.py [modify] https://crrev.com/41a3c7960eb329b2292933f45a03623930b6bab5/lib/paygen/paygen_payload_lib.py
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/527d0604ab5ddb68549c24b0396cd5ba6c75f813 commit 527d0604ab5ddb68549c24b0396cd5ba6c75f813 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Apr 03 23:39:32 2018 Roll src/third_party/chromite/ 87c1c3dbe..ec8d7a766 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/87c1c3dbea9a..ec8d7a766a7e $ git log 87c1c3dbe..ec8d7a766 --date=short --no-merges --format='%ad %ae %s' 2018-03-01 achuith [chrome_committer]: Split out chrome_committer. 2018-03-08 ahassani paygen: Log all chroot operations in the log file 2018-03-08 ahassani paygen: Check for the correct metadata size in the verify section Created with: roll-dep src/third_party/chromite BUG= chromium:814910 , chromium:808495 , chromium:820243 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2dc84a4feb54038e73df54f3f123e7cf8e6d3ae0 Reviewed-on: https://chromium-review.googlesource.com/993704 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547869} [modify] https://crrev.com/527d0604ab5ddb68549c24b0396cd5ba6c75f813/DEPS
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c27a6612dbaee1223227c24ed961abc6d7e4f134 commit c27a6612dbaee1223227c24ed961abc6d7e4f134 Author: Amin Hassani <ahassani@chromium.org> Date: Wed Jun 13 04:50:58 2018 paygen: Remove au-generator.zip We now do paygen in chroot. There is no need for au-generator anymore. Remove any uses cases of it. BUG= chromium:808495 TEST=tryjob payload Change-Id: I5d01cfb1273ddbe80fc7011a5769c44961497564 Reviewed-on: https://chromium-review.googlesource.com/1085687 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cli/cros/README.cros_moblabvm.md [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/contrib/channelsign [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/commands.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/lib/paygen/gspaths.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/lib/paygen/gspaths_unittest.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/scripts/pushimage_unittest.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/stages/test_stages_unittest.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/lib/paygen/paygen_payload_lib_unittest.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/stages/test_stages.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/scripts/pushimage.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/stages/build_stages.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/lib/paygen/paygen_payload_lib.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/stages/artifact_stages.py [modify] https://crrev.com/c27a6612dbaee1223227c24ed961abc6d7e4f134/cbuildbot/commands_unittest.py
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/2a14d41ca514eca784b7b065791eaf97685caad8 commit 2a14d41ca514eca784b7b065791eaf97685caad8 Author: Amin Hassani <ahassani@chromium.org> Date: Wed Jun 13 04:50:52 2018 update_payload: Remove instances to au-generator We now do paygen in chroot. There is no need for au-generator anymore. So remove all references to it. BUG= chromium:808495 TEST=tryjob payload Change-Id: I0d0e76cc1dd7a742abdd9b3b457709044af98862 Reviewed-on: https://chromium-review.googlesource.com/1085547 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org> [modify] https://crrev.com/2a14d41ca514eca784b7b065791eaf97685caad8/scripts/brillo_update_payload
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/d98f2d95610d0f3a441d7bca0a3ea91dd3d1ef59 commit d98f2d95610d0f3a441d7bca0a3ea91dd3d1ef59 Author: Amin Hassani <ahassani@chromium.org> Date: Wed Jun 13 04:50:43 2018 dev-utils: Remove au-generator.zip We now do paygen in chroot. There is no need for au-generator anymore. Remove any instance references to it. BUG= chromium:808495 TEST=tryjob payload Change-Id: Ic84d5787ae484cda9bb96d5d1c4c912dc88c3458 Reviewed-on: https://chromium-review.googlesource.com/1085688 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d98f2d95610d0f3a441d7bca0a3ea91dd3d1ef59/host/cros_generate_update_payload [modify] https://crrev.com/d98f2d95610d0f3a441d7bca0a3ea91dd3d1ef59/build_artifact_unittest.py
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/058e3c7ff2acdd5344c18417993091124cb0919c commit 058e3c7ff2acdd5344c18417993091124cb0919c Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 13 06:42:52 2018 Roll src/third_party/chromite 11376cfc6fe9..c27a6612dbae (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/11376cfc6fe9..c27a6612dbae git log 11376cfc6fe9..c27a6612dbae --date=short --no-merges --format='%ad %ae %s' 2018-06-13 ahassani@chromium.org paygen: Remove au-generator.zip Created with: gclient setdep -r src/third_party/chromite@c27a6612dbae The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I5cd621b2dcccf248570fdd215ec497a277003059 Reviewed-on: https://chromium-review.googlesource.com/1098238 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566738} [modify] https://crrev.com/058e3c7ff2acdd5344c18417993091124cb0919c/DEPS
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b commit 2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b Author: Amin Hassani <ahassani@chromium.org> Date: Thu Jun 14 21:40:52 2018 paygen: remove work_dir from CreateAndUploadPayload No need for work_dir since we are using /tmp in chroot. BUG= chromium:808495 TEST=tryjob payload Change-Id: Ia5b906d038a3e9c56417621d7feaabf4c09e861a Reviewed-on: https://chromium-review.googlesource.com/1094153 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b/lib/paygen/paygen_build_lib.py [modify] https://crrev.com/2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b/lib/paygen/paygen_payload_lib_unittest.py [modify] https://crrev.com/2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b/lib/paygen/paygen_build_lib_unittest.py [modify] https://crrev.com/2f47d1dbafe20537e0eb2f55aa9d70a5496a2b7b/lib/paygen/paygen_payload_lib.py
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/e3843c9f88e2f26c10d588fda9819ad20210c14d commit e3843c9f88e2f26c10d588fda9819ad20210c14d Author: Amin Hassani <ahassani@chromium.org> Date: Thu Jun 14 21:40:53 2018 Remove au-generator.zip We now do paygen in chroot. There is no need for au-generator anymore. BUG= chromium:808495 TEST=tryjob payload Change-Id: I6d6a198d04cc1c3b9fc3ce7d20885ad604fe5393 Reviewed-on: https://chromium-review.googlesource.com/1085689 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/9e658a9550baf51993f54d96f37473866c58b17f/build_library/generate_au_zip.py [delete] https://crrev.com/9e658a9550baf51993f54d96f37473866c58b17f/build_library/test_au_zip.py
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2d2e45698c1c6ef63b788b98df3092e2d268f8b commit b2d2e45698c1c6ef63b788b98df3092e2d268f8b Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 15 01:46:08 2018 Roll src/third_party/chromite 54899e2b1191..90d481078b9b (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/54899e2b1191..90d481078b9b git log 54899e2b1191..90d481078b9b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 dgarrett@google.com chromeos-config: Move asan's to chrome_informational. 2018-06-14 ahassani@chromium.org paygen: remove work_dir from CreateAndUploadPayload Created with: gclient setdep -r src/third_party/chromite@90d481078b9b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I128fcfb6d7c2424b3677638683809584a41efb62 Reviewed-on: https://chromium-review.googlesource.com/1101721 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567509} [modify] https://crrev.com/b2d2e45698c1c6ef63b788b98df3092e2d268f8b/DEPS
,
Sep 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ahass...@chromium.org
, Feb 2 2018